fix node version parsing when using --node=system#62
Merged
ekalinin merged 1 commit intoekalinin:masterfrom May 7, 2014
Merged
fix node version parsing when using --node=system#62ekalinin merged 1 commit intoekalinin:masterfrom
ekalinin merged 1 commit intoekalinin:masterfrom
Conversation
ekalinin
added a commit
that referenced
this pull request
May 7, 2014
fix node version parsing when using --node=system
Owner
|
Thanks! Merged. |
Contributor
|
++ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opt.node is set to 'system', parse_version(opt.node) invariantly returns ('_system', '_final') which is always less than parse_version("0.6.3"). I've changed the code to check the node version on the system if the developer wants to use the system node.