Conversation
* Make the `Functor`, `Applicative`, `Apply`, and `ComonadApply` instances for all the `Bazaar*` types use all the underlying methods. This could be important if those are specially optimized. I checked on this because I'd like us to use `liftA2` for `holesOf` when possible, which may reduce lazy tuple shuffling. I don't think the rest are too important for `lens`, since legitimate traversals generally shouldn't be using `<$`, `<*`, `*>`, etc., but someone might be using the types for some other purpose where those are more relevant. * Add a missing `MINIMAL` pragma for `IndexedComonad`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
Functor,Applicative,Apply, andComonadApplyinstances for all the
Bazaar*types use all the underlyingmethods. This could be important if those are specially optimized.
In particu
Add a missing
MINIMALpragma forIndexedComonad.