filebeat: remove redundant beatPaths parameters#49842
filebeat: remove redundant beatPaths parameters#49842orestisfl wants to merge 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
2fbb8ea to
7f84b30
Compare
7f84b30 to
8fdfb6d
Compare
This comment has been minimized.
This comment has been minimized.
TL;DRAll 6 failed Buildkite jobs are failing before packaging starts because the PR cannot be auto-merged with Remediation
Investigation detailsRoot CauseThis is a mergeability failure (branch drift), not a packaging/runtime failure. In all failed jobs, Buildkite’s repo post-checkout hook attempts to create a PR merge branch and exits on the same conflict:
The conflicting area aligns with large divergence between current Evidence
Verification
Follow-upAfter rebase conflict resolution, rerun the same Buildkite packaging matrix to confirm the failure is cleared. Note 🔒 Integrity filtering filtered 1 itemIntegrity filtering activated and filtered the following item during workflow execution.
What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
8fdfb6d to
c8a1d37
Compare
Now that Paths lives in beat.Info, functions that already receive Info no longer need a separate paths parameter. This removes the redundant parameter from fileset factories, module registry, default-inputs Init, openStateStore, and the PluginFactory type.
c8a1d37 to
07c7fb6
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThis change refactors path parameter handling across the Filebeat codebase by removing explicit ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mauri870
left a comment
There was a problem hiding this comment.
Thanks! I have been getting some linter failures on changes that touch some of these files, because of the global paths lint. I'm glad it's fixed.
Proposed commit message
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. Internal API change only.
How to test this PR locally
Related issues
Beat.Info#49803