Add new required_fields as a build-time restricted field#2059
Merged
Mikaayenson merged 19 commits intomainfrom Jul 6, 2022
Merged
Add new required_fields as a build-time restricted field#2059Mikaayenson merged 19 commits intomainfrom
required_fields as a build-time restricted field#2059Mikaayenson merged 19 commits intomainfrom
Conversation
Mikaayenson
requested review from
brokensound77 and
terrancedejesus
as code owners
Mikaayenson
commented
Jun 27, 2022
brokensound77
changed the title
require_field restricted fieldrequired_fields as a build-time restricted field
terrancedejesus
approved these changes
Jun 28, 2022
Contributor
terrancedejesus
left a comment
terrancedejesus
left a comment
There was a problem hiding this comment.
Reviewed and tested with @Mikaayenson
Contributor
|
c59f224 I expanded the schema and values to include the additional fields. I had to do additional checks on ECS and beats schema to make the determination. For lucene rules, this will be skipped since they are not parsed (empty array). Until we add integration schemas, it has the potential to not be perfect on field type determination (#1994). It also does not parse into I successfully uploaded the full rule set to an 8.3 stack (the error is unrelated)
|
Mikaayenson
commented
Jul 1, 2022
brokensound77
approved these changes
Jul 5, 2022
Contributor
brokensound77
left a comment
brokensound77
left a comment
There was a problem hiding this comment.
A few small changes then LGTM. Thanks for diving into this. We should pay special attention on this backport and before the next lock.
Mikaayenson
deleted the
2056-add-required_fields-to-post-transform-build-process
branch
protectionsmachine
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Add new `require_field` restricted field * validate new fields against BaseRuleData schema and global constant Co-authored-by: Terrance DeJesus <terrance.dejesus@elastic.co> Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit c76a397)
protectionsmachine
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Add new `require_field` restricted field * validate new fields against BaseRuleData schema and global constant Co-authored-by: Terrance DeJesus <terrance.dejesus@elastic.co> Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit c76a397)
protectionsmachine
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Add new `require_field` restricted field * validate new fields against BaseRuleData schema and global constant Co-authored-by: Terrance DeJesus <terrance.dejesus@elastic.co> Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit c76a397)
protectionsmachine
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Add new `require_field` restricted field * validate new fields against BaseRuleData schema and global constant Co-authored-by: Terrance DeJesus <terrance.dejesus@elastic.co> Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit c76a397)
protectionsmachine
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Add new `require_field` restricted field * validate new fields against BaseRuleData schema and global constant Co-authored-by: Terrance DeJesus <terrance.dejesus@elastic.co> Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit c76a397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #2056
Summary
unique_fieldsin the post buildrequired_fieldsto the rule post build.