[RFC 0053][Update] Stage2: New device fields #2530
Conversation
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2530/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
| level: extended | ||
| type: keyword | ||
| short: ProductID of the device | ||
| description: > |
There was a problem hiding this comment.
you should add also links to what exactly product ID is (as in phase 0 PR)
You should treat each description in a way that everyone, who wants to use this field, should understand how the field is generated (or what constraints it has)
There was a problem hiding this comment.
so while short might be the same as in phase 0, description should elaborate more details on it
There was a problem hiding this comment.
@trisch-me added proper description for each field.
Is it fine to include links to the microsoft documentation about vid and pid?
Their documentation is very well written
|
@mjwolf I will wait for your review before merge |
This PR proposes changes on top of:
Added fields based on previous PR: