Conversation
…implemented and tested
|
@codebrain mind retargetting this against |
|
Changed base to 6.6 |
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM 👍 left a few small comments.
I added a fix for failing unit tests related to there being no event id when unit tests are run.
| public partial interface IDeleteCalendarJobResponse : IResponse | ||
| { | ||
| [JsonProperty("calendar_id")] | ||
| Id CalendarId { get; } |
There was a problem hiding this comment.
Do we typically return Nest types like Id on responses, or leave them as primitive types e.g. string?
There was a problem hiding this comment.
Good catch, will change to string - I think that is better and will likely play nicer with a different serialiser.
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// Retrieves configuration for machine learning jobs. |
There was a problem hiding this comment.
Retrieves calendar configuration information for machine learning jobs?
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// Instantiates a machine learning calendar. |
There was a problem hiding this comment.
Maybe Creates might be better here?
|
Ported to |
|
Subsequent commit made to address other types in response objects, not merged as part of this commit. This was also ported to |
(cherry picked from commit 2f040c4)
3 participants
Implementation of the
6.4.0ML calendar APIs - see here: #3552Requires port to
master