Skip to content

Use trim-safe code in LazyJsonConverter. #8793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −3
Open

Use trim-safe code in LazyJsonConverter. #8793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b9308b
Use trim-safe code in `LazyJsonConverter`.
teo-tsirpanis Dec 8, 2025
e949c96
Merge branch 'main' into fix-trim
teo-tsirpanis Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Elastic.Clients.Elasticsearch/_Shared/Core/LazyJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ public sealed class LazyJsonConverter : JsonConverter<LazyJson>
{
private IElasticsearchClientSettings? _settings;

[UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute'", Justification = "Always using explicit TypeInfoResolver")]
[UnconditionalSuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute'", Justification = "Always using explicit TypeInfoResolver")]
public override LazyJson Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
InitializeSettings(options);

return new LazyJson(JsonSerializer.Deserialize<JsonElement>(ref reader, options), _settings!);
return new LazyJson(JsonElement.ParseValue(ref reader), _settings!);
}

private void InitializeSettings(JsonSerializerOptions options)
Expand Down
Loading