Disable assemble task instead of removing it (#33348)

Author: alpar-t

benchmarks/build.gradle

@@ -21,10 +21,7 @@ apply plugin: 'elasticsearch.build'
 apply plugin: 'application'
 mainClassName = 'org.openjdk.jmh.Main'
 
-// Not published so no need to assemble
-tasks.remove(assemble)
-build.dependsOn.remove('assemble')
-
+assemble.enabled = false
 archivesBaseName = 'elasticsearch-benchmarks'
 mainClassName = 'org.openjdk.jmh.Main'
 

build.gradle

@@ -583,13 +583,11 @@ gradle.projectsEvaluated {
     if (project.path.startsWith(':qa')) {
       Task assemble = project.tasks.findByName('assemble')
       if (assemble) {
-        project.tasks.remove(assemble)
-        project.build.dependsOn.remove('assemble')
+        assemble.enabled = false
       }
       Task dependenciesInfo = project.tasks.findByName('dependenciesInfo')
       if (dependenciesInfo) {
-        project.tasks.remove(dependenciesInfo)
-        project.precommit.dependsOn.remove('dependenciesInfo')
+        dependenciesInfo.enabled = false
       }
     }
   }

buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy

@@ -547,7 +547,7 @@ class BuildPlugin implements Plugin<Project> {
             }
             // build poms with assemble (if the assemble task exists)
             Task assemble = project.tasks.findByName('assemble')
-            if (assemble) {
+            if (assemble && assemble.enabled) {
                 assemble.dependsOn(generatePOMTask)
             }
         }

buildSrc/src/main/groovy/org/elasticsearch/gradle/doc/DocsTestPlugin.groovy

@@ -35,8 +35,7 @@ public class DocsTestPlugin extends RestTestPlugin {
         // The distribution can be configured with -Dtests.distribution on the command line
         project.integTestCluster.distribution = System.getProperty('tests.distribution', 'zip')
         // Docs are published separately so no need to assemble
-        project.tasks.remove(project.assemble)
-        project.build.dependsOn.remove('assemble')
+        project.tasks.assemble.enabled = false
         Map<String, String> defaultSubstitutions = [
             /* These match up with the asciidoc syntax for substitutions but
              * the values may differ. In particular {version} needs to resolve

client/benchmark/build.gradle

@@ -23,8 +23,7 @@ apply plugin: 'application'
 group = 'org.elasticsearch.client'
 
 // Not published so no need to assemble
-tasks.remove(assemble)
-build.dependsOn.remove('assemble')
+assemble.enabled = true
 
 archivesBaseName = 'client-benchmarks'
 mainClassName = 'org.elasticsearch.client.benchmark.BenchmarkMain'

client/client-benchmark-noop-api-plugin/build.gradle

@@ -28,8 +28,7 @@ esplugin {
 }
 
 // Not published so no need to assemble
-tasks.remove(assemble)
-build.dependsOn.remove('assemble')
+assemble.enabled = false
 
 dependencyLicenses.enabled = false
 dependenciesInfo.enabled = false

distribution/bwc/build.gradle

@@ -50,8 +50,7 @@ subprojects {
 
   apply plugin: 'distribution'
   // Not published so no need to assemble
-  tasks.remove(assemble)
-  build.dependsOn.remove('assemble')
+  assemble.enabled = false
 
   File checkoutDir = file("${buildDir}/bwc/checkout-${bwcBranch}")
 

plugins/examples/build.gradle

@@ -3,8 +3,7 @@ gradle.projectsEvaluated {
   subprojects {
     Task assemble = project.tasks.findByName('assemble')
     if (assemble) {
-      project.tasks.remove(assemble)
-      project.build.dependsOn.remove('assemble')
+      assemble.enabled = false
     }
   }
 }

x-pack/plugin/ccr/qa/build.gradle

@@ -5,8 +5,7 @@ gradle.projectsEvaluated {
   subprojects {
     Task assemble = project.tasks.findByName('assemble')
     if (assemble) {
-      project.tasks.remove(assemble)
-      project.build.dependsOn.remove('assemble')
+      assemble.enabled = false
     }
   }
 }

x-pack/plugin/ml/qa/build.gradle

@@ -20,12 +20,11 @@ gradle.projectsEvaluated {
     subprojects {
         Task assemble = project.tasks.findByName('assemble')
         if (assemble) {
-            project.tasks.remove(assemble)
-            project.build.dependsOn.remove('assemble')
+            assemble.enabled = false
         }
         Task dependenciesInfo = project.tasks.findByName('dependenciesInfo')
         if (dependenciesInfo) {
-            project.precommit.dependsOn.remove('dependenciesInfo')
+            dependenciesInfo.enabled = false
         }
     }
 }