Disable assemble task instead of removing it#33348
Merged
alpar-t merged 2 commits intoelastic:masterfrom Sep 4, 2018
Merged
Conversation
alpar-t
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
approved these changes
Sep 3, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I left one nit. Let’s get this in so we can get a new snapshot built, we have pushed some major changes in the last few days.
| // build poms with assemble (if the assemble task exists) | ||
| Task assemble = project.tasks.findByName('assemble') | ||
| if (assemble) { | ||
| if (assemble && assemble.enabled == true) { |
Member
There was a problem hiding this comment.
I think we can do without == true here.
alpar-t
added a commit
that referenced
this pull request
Sep 4, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 4, 2018
…e-default-distribution * elastic/master: (213 commits) ML: Fix build after HLRC change Fix inner hits retrieval when stored fields are disabled (_none_) (elastic#33018) SQL: Show/desc commands now support table ids (elastic#33363) Mute testValidateFollowingIndexSettings HLRC: Add delete by query API (elastic#32782) [ML] The sort field on get records should default to the record_score (elastic#33358) [ML] Minor improvements to categorization Grok pattern creation (elastic#33353) [DOCS] fix a couple of typos (elastic#33356) Disable assemble task instead of removing it (elastic#33348) Simplify the return type of FieldMapper#parse. (elastic#32654) [ML] Delete forecast API (elastic#31134) (elastic#33218) Introduce private settings (elastic#33327) [Docs] Add search timeout caveats (elastic#33354) TESTS: Fix Race Condition in Temp Path Creation (elastic#33352) Fix from_range in search_after in changes snapshot (elastic#33335) TESTS+DISTR.: Fix testIndexCheckOnStartup Flake (elastic#33349) Null completion field should not throw IAE (elastic#33268) Adds code to help with IndicesRequestCacheIT failures (elastic#33313) Prevent NPE parsing the stop datafeed request. (elastic#33347) HLRC: Add ML get overall buckets API (elastic#33297) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now running
./gradlew assemblefails because of projects that remove it.Gradle is making steps to make it impossible to remove tasks, there are already deprecation around it,
and it seems like removing tasks doesn't remove them from everywhere.
The problem was triggered by cd378d5 which on the surface has nothing to do with how this failed.
There's also #33343 for dealing with the testing task.
With this change, the assemble task is disabled instead of removed so we are more in-line with what Gradle expects.
On the long term I would like to move publishing into it's own plugin instead of assigning special meaning to disabling the
assembletask, making it opt-in rather than opt-out.