Error log when license verification fails locally#102919
Merged
albertzaharovits merged 10 commits intoelastic:mainfrom Dec 5, 2023
Merged
Error log when license verification fails locally#102919albertzaharovits merged 10 commits intoelastic:mainfrom
albertzaharovits merged 10 commits intoelastic:mainfrom
Conversation
albertzaharovits
added
WIP
:Security/License
albertzaharovits
changed the title
Contributor
Author
|
Note to reviewers: I recommend reviewing the PR commit-by-commit. |
Collaborator
|
Hi @albertzaharovits, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
jakelandis
approved these changes
Dec 4, 2023
| } | ||
|
|
||
| private void maybeRegisterOrUpdateLicense(ClusterState previousClusterState, ClusterState currentClusterState) { | ||
| if (XPackPlugin.isReadyForXPackCustomMetadata(currentClusterState) == false) { |
Contributor
There was a problem hiding this comment.
+1 to completely remove this whole if block if you choose to ... i started to remove these across the board... but kinda forgot about it: #95428
Contributor
Author
There was a problem hiding this comment.
Ah, thank you for the indication!
I also wanted to ask about it, but similarly omitted....
I've pushed 0c360c2 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements logging if the license verification fails on local nodes
(after the the license has already been (erroneously) published in the cluster state).
This also contains some arguable minor code refactoring that I hope help with code readability.