Fix geoip processor isp_organization_name property and docs#111372
Merged
joegallo merged 4 commits intoelastic:mainfrom Jul 26, 2024
Merged
Fix geoip processor isp_organization_name property and docs#111372joegallo merged 4 commits intoelastic:mainfrom
joegallo merged 4 commits intoelastic:mainfrom
Conversation
joegallo
added
>bug
:Distributed/Ingest Node
Contributor
|
Documentation preview: |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @joegallo, I've created a changelog YAML for you. |
masseyke
approved these changes
Jul 26, 2024
Contributor
Author
|
A quick process note: this is a new field as of 8.15.0, so as long as this PR ends up in the 8.15.0 release I do not think this can be fairly construed as a breaking change, it's just a bugfix. OTOH if this PR doesn't land for 8.15.0, then we might want to consider other approaches. |
joegallo
added
the
auto-backport
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 26, 2024
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property that you put into the
geoipprocessorpropertieslist isisp_organization_name(no change), but the docs accidentally said that it'sisp_organization, so this PR fixes that. Additionally the field that was written into the output object was alsoisp_organization, and this PR fixes that as well.While a bit verbose, it's all intended to mirror the
organization_namefor the ASN database, so there's a reason for it to be what it is.