Skip to content

[Build] Skip yamlRestTestCompatibility tests when no previous unreleased minor#139648

Open
breskeby wants to merge 4 commits intoelastic:mainfrom
breskeby:skip-yaml-compatible-for-no-minor
Open

[Build] Skip yamlRestTestCompatibility tests when no previous unreleased minor#139648
breskeby wants to merge 4 commits intoelastic:mainfrom
breskeby:skip-yaml-compatible-for-no-minor

Conversation

@breskeby
Copy link
Copy Markdown
Contributor

This was brought up by the community and by the performance team. We should keep
even older branches buildable as best as possible.

This fixes a configuration issue of yamlRestTestCompatibility tests when no unreleased
previous major is available.

…sed minor

This was brought up by the community and by the performance team. We should keep
even older branches buildable as best as possible.

This fixes a configuration issue of yamlRestTestCompatibility tests when no unreleased
previous major is available.
@breskeby breskeby requested a review from a team as a code owner December 16, 2025 21:21
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v9.3.0 v9.1.10 v9.2.4 v8.19.10 labels Dec 16, 2025
@breskeby breskeby self-assigned this Dec 16, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby removed the v9.0.9 label Dec 16, 2025
Copy link
Copy Markdown
Contributor

@jozala jozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but I have some general questions.

Do I understand correctly that without this fix, it now fail for 8.19 branch, because for 9.x branches we still have previous major last version unreleased, but not for 8.19?

Why do we always use previous major last unreleased version for that? I understand there might be a case (like for 8.19 now) that there is no such version. Should we use the last released version then instead of not running the tests at all?

@breskeby
Copy link
Copy Markdown
Contributor Author

breskeby commented Dec 23, 2025 via email

@jozala
Copy link
Copy Markdown
Contributor

jozala commented Dec 29, 2025

This originally came up as 9.0 was failing to be configured as there was no previous minor or did not calculate correctly. We assume here that there is always a previous unreleased version but often there isn't. e.g for 9.0. 8.19 is not compatible as 9.0 is only compatible with 8.18

Is it expected that we skip these tests when there is no previous unreleased version or we should use previous released version in that case?
We still care about the REST compatibility in those cases, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.19.15 v9.1.11 v9.2.9 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants