Update aws java sdk to support ecs task roles by matarrese · Pull Request #25552 · elastic/elasticsearch

matarrese · 2017-07-05T13:38:42Z

Hi,
there are some failing tests, so it should not be considered as a ready to be reviewed pull request? Just to know if it's something related what you were talking about here: #23039

This reverts commit 1fabfae.

karmi · 2017-07-05T13:38:44Z

Hi @matarrese, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2017-07-05T13:38:45Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

matarrese · 2017-07-05T15:55:23Z

Thank you @karmi for your prompt reply.
I have added the email to my profile

tedder · 2017-08-04T09:54:05Z

Any updates here?

matarrese · 2017-09-12T10:00:33Z

Solved by #26479

dadoonet · 2017-09-12T11:57:33Z

OMG! I'm very sorry I did not see your PR before I merged the other one. :shame:

mohit · 2017-09-12T22:26:12Z

actually @matarrese #26479 does not update the SDK for repository-s3 which your PR does, so I still think this PR would be worth getting to master.

dadoonet · 2017-09-12T23:28:55Z

True. @matarrese wanna add some missing bits to your PR?

elasticmachine · 2017-09-12T23:28:57Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

matarrese · 2017-09-28T15:45:52Z

Hi @dadoonet, I missed the new updates on this.
Does this pull request need more work? Or is it ready to be reviewed?

dadoonet

Left a comment.
Please run also gradle check. It will most likely fail as the SHA1 changed for the new jars. Could you fix it as well?

dadoonet · 2017-09-28T16:40:18Z

plugins/repository-s3/build.gradle


 versions << [
-  'aws': '1.10.69'
+  'aws': '1.11.16'


Could you update it to 1.11.187 to align with what we have in #26479?

dadoonet · 2017-09-29T13:40:02Z

@matarrese Did you run gradle check locally?

matarrese · 2017-10-02T16:02:35Z

Hi @dadoonet , now seems fine to me locally.
Let me know if we need further changes!

dadoonet · 2017-10-02T16:30:44Z

jenkins test it please

dadoonet · 2017-10-02T16:32:04Z

I'm surprised gradle check is passing well without changing the SHA1 files. Let see what Jenkins says.

dadoonet · 2017-10-02T17:11:33Z

As I told you it failed with:

16:35:47 Checking sha for aws-java-sdk-s3-1.11.187.jar
16:35:47 :plugins:repository-s3:dependencyLicenses FAILED
16:35:47 :plugins:repository-s3:dependencyLicenses (Thread[main,5,main]) completed. Took 0.004 secs.
16:35:47 
16:35:47 FAILURE: Build failed with an exception.
16:35:47 
16:35:47 * What went wrong:
16:35:47 Execution failed for task ':plugins:repository-s3:dependencyLicenses'.
16:35:47 > Missing SHA for aws-java-sdk-s3-1.11.187.jar. Run 'gradle updateSHAs' to create

Run:

gradle :plugins:repository-s3:updateSHAs
gradle :plugins:repository-s3:check

And commit the changes. Thanks!

dadoonet · 2017-10-03T13:35:55Z

jenkins test it please

rjernst · 2018-01-09T22:06:52Z

@elasticmachine test this please

matarrese · 2018-01-14T11:30:44Z

@rjernst could you please test this branch again?

rjernst · 2018-01-15T07:41:40Z

@elasticmachine test this please

* master: (74 commits) Update version of TaskInfo header serialization after backport TEST: Tightens file-based condition in peer-recovery Correct backport replica rollback to 6.2 (elastic#28181) Backport replica rollback to 6.2 (elastic#28181) Rename deleteLocalTranslog to createNewTranslog AwaitsFix #testRecoveryAfterPrimaryPromotion TEST: init unassigned gcp in testAcquireIndexCommit Replica start peer recovery with safe commit (elastic#28181) Truncate tlog cli should assign global checkpoint (elastic#28192) Fix lock accounting in releasable lock Add ability to associate an ID with tasks (elastic#27764) [DOCS] Removed differencies between text and code (elastic#27993) text fixes (elastic#28136) Update getting-started.asciidoc (elastic#28145) [Docs] Spelling fix in painless-getting-started.asciidoc (elastic#28187) Fixed the cat.health REST test to accept 4ms, not just 4.0ms (elastic#28186) Do not keep 5.x commits once having 6.x commits (elastic#28188) Rename core module to server (elastic#28180) upgraded jna from 4.4.0-1 to 4.5.1 (elastic#28183) [TEST] Do not call RandomizedTest.scaledRandomIntBetween from multiple threads ...

rjernst · 2018-01-16T05:14:11Z

@elasticmachine test this please

rjernst · 2018-01-24T06:54:59Z

@elasticmachine test this please

rjernst · 2018-01-28T04:49:11Z

@matarrese I think you need to remove the sha files you are adding to the licenses dir, as those were from a previous version of this PR when you had updated the sdk version.

The test failure looks unrelated. If you remove those sha files, I will trigger tests once more, and if there are still unrelated failures I will pull and test this manually.

matarrese · 2018-02-04T12:26:05Z

Hi @rjernst , I have removed the generated sha files.

rjernst · 2018-02-09T22:56:40Z

@elasticmachine test this please

rjernst · 2018-02-26T00:12:52Z

@elasticmachine test this please

rjernst · 2018-12-06T22:01:12Z

This was actually picked up in #31864 by someone unaware of this old PR. I'm going to close this as it is no longer necessary, but thank you for the contribution @matarrese!

matarrese added 3 commits June 27, 2017 16:24

Update AWS Java SDK to support ECS Task Roles

1fabfae

Revert "Update AWS Java SDK to support ECS Task Roles"

2f275f3

This reverts commit 1fabfae.

Update AWS Java SDK to support ECS Task Roles

6e5482a

matarrese closed this Sep 12, 2017

dadoonet reopened this Sep 12, 2017

dadoonet self-assigned this Sep 12, 2017

dadoonet added :Plugin Repository S3 labels Sep 12, 2017

dadoonet requested changes Sep 28, 2017

View reviewed changes

matarrese added 2 commits September 29, 2017 13:52

merging

caa98d6

update aws version

85ce750

s3 update library

fb79f62

missing space

907f0ac

new generate sha1

f2eb80e

rename inner class in AwsS3Service

008edf6

colings86 added v6.3.0 and removed v6.2.0 labels Jan 22, 2018

delete old generated sha1

5c32ae8

dadoonet removed their assignment Feb 5, 2018

clintongormley added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Repository S3 labels Feb 14, 2018

colings86 added the >enhancement label Apr 24, 2018

bleskes added v6.3.1 v6.4.0 and removed v6.3.0 v6.3.1 labels Apr 26, 2018

tlrx mentioned this pull request May 18, 2018

Update AWS SDK to 1.11.340 in repository-s3 #30723

Merged

lcawl added v6.4.1 and removed v6.4.0 labels Aug 23, 2018

rjernst removed the review label Oct 10, 2018

rjernst closed this Dec 6, 2018

jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Conversation

matarrese commented Jul 5, 2017 • edited by dadoonet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karmi commented Jul 5, 2017

Uh oh!

elasticmachine commented Jul 5, 2017

Uh oh!

matarrese commented Jul 5, 2017

Uh oh!

tedder commented Aug 4, 2017

Uh oh!

matarrese commented Sep 12, 2017

Uh oh!

dadoonet commented Sep 12, 2017

Uh oh!

mohit commented Sep 12, 2017

Uh oh!

dadoonet commented Sep 12, 2017

Uh oh!

elasticmachine commented Sep 12, 2017

Uh oh!

matarrese commented Sep 28, 2017

Uh oh!

dadoonet left a comment

Choose a reason for hiding this comment

Uh oh!

dadoonet Sep 28, 2017

Choose a reason for hiding this comment

Uh oh!

dadoonet commented Sep 29, 2017

Uh oh!

matarrese commented Oct 2, 2017

Uh oh!

dadoonet commented Oct 2, 2017

Uh oh!

dadoonet commented Oct 2, 2017

Uh oh!

dadoonet commented Oct 2, 2017

Uh oh!

dadoonet commented Oct 3, 2017

Uh oh!

rjernst commented Jan 9, 2018

Uh oh!

matarrese commented Jan 14, 2018

Uh oh!

rjernst commented Jan 15, 2018

Uh oh!

rjernst commented Jan 16, 2018

Uh oh!

rjernst commented Jan 24, 2018

Uh oh!

rjernst commented Jan 28, 2018

Uh oh!

matarrese commented Feb 4, 2018

Uh oh!

rjernst commented Feb 9, 2018

Uh oh!

rjernst commented Feb 26, 2018

Uh oh!

rjernst commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

matarrese commented Jul 5, 2017 •

edited by dadoonet

Loading