Don't refresh on _flush _force_merge and _upgrade#27000
Merged
s1monw merged 7 commits intoelastic:masterfrom Oct 16, 2017
Merged
Don't refresh on _flush _force_merge and _upgrade#27000s1monw merged 7 commits intoelastic:masterfrom
_flush _force_merge and _upgrade#27000s1monw merged 7 commits intoelastic:masterfrom
Conversation
Today all these API calls have a sideeffect of making documents visible to search requests. While this is sometimes desired it's an unnecessary sideeffect and now that we have an internal (engine-private) index reader (elastic#26972) we artificially add a refresh call for bwc. This change removes this sideeffect in 7.0.
s1monw
added
:Core/Infra/Core
Contributor
clintongormley
left a comment
clintongormley
left a comment
There was a problem hiding this comment.
Looks good to me, and I think it is the right way to go. It needs a note in the breaking changes docs.
bleskes
approved these changes
Oct 13, 2017
Contributor
Author
|
@clintongormley I pushed a migration guide note |
clintongormley
approved these changes
Oct 13, 2017
Contributor
Author
|
@elasticmachine test this please |
jasontedor
added a commit
that referenced
this pull request
Oct 16, 2017
* master: Remove unnecessary exception for engine constructor Update docs about `script` parameter (#27010) Don't refresh on `_flush` `_force_merge` and `_upgrade` (#27000) Do not set SO_LINGER on server channels (#26997) Fix inconsistencies in the rest api specs for *_script (#26971) fix inconsistencies in the rest api specs for cat.snapshots (#26996) Add docs on full_id parameter in cat nodes API [TEST] Add test that replicates versioned updates with random flushes Use internal searcher for all indexing related operations in the engine Reformat paragraph in template docs to 80 columns Clarify settings and template on create index Fix reference to TcpTransport in documentation Allow Uid#decodeId to decode from a byte array slice (#26987) Fix a typo in the similarity docs (#26970) Use separate searchers for "search visibility" vs "move indexing buffer to disk (#26972)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today all these API calls have a sideeffect of making documents visible
to search requests. While this is sometimes desired it's an unnecessary sideeffect
and now that we have an internal (engine-private) index reader (#26972) we artificially
add a refresh call for bwc. This change removes this sideeffect in 7.0.