rest-api-spec : setting path parts as required to reflect the code base

[olcbean]

Setting path parts as required when needed in the rest-spec-apis.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[dakrone]

Thanks @olcbean, I left a comment

[dakrone]

This is not actually required, you can do GET /_tasks no problem

[olcbean]

@dakrone you are correct! But when you call GET /_tasks without task_id, it is mapped to :

elasticsearch/core/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestListTasksAction.java

Lines 52 to 56 in 3deba0e

	public RestListTasksAction(Settings settings, RestController controller, Supplier<DiscoveryNodes> nodesInCluster) {
	super(settings);
	this.nodesInCluster = nodesInCluster;
	controller.registerHandler(GET, "/_tasks", this);
	}

defined by tasks.list in the rest-api-specs.

tasks.get is for :

elasticsearch/core/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestGetTaskAction.java

Lines 37 to 40 in 3deba0e

	public RestGetTaskAction(Settings settings, RestController controller) {
	super(settings);
	controller.registerHandler(GET, "/_tasks/{task_id}", this);
	}

[dakrone]

That's true, and there is the other .json spec file that mentions solely /_tasks

Hmm... I'm not sure what the best thing for this situation is, perhaps leaving it as required is the best since it only pertains to this particular API (not tasks.list.json)

[javanna]

are there downsides for this change in the spec? I think it makes sense in the context of the get task API.

[dakrone]

@javanna yeah I think it does too, I just wanted to think about it for a little bit. I'll merge this.

[dakrone]

@elasticmachine test this please

[dakrone]

Thanks @olcbean!