Skip to content

[Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing#27717

Merged
martijnvg merged 1 commit intoelastic:masterfrom
avneesh91:contributing_command_clarification
Dec 8, 2017
Merged

[Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing#27717
martijnvg merged 1 commit intoelastic:masterfrom
avneesh91:contributing_command_clarification

Conversation

@avneesh91
Copy link
Copy Markdown
Contributor

@avneesh91 avneesh91 commented Dec 8, 2017

  1. Added the Application to the edit configurations help section for IntelliJ.
  2. Added information about how to run a local copy of elasticsearch from the source.

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 8, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@avneesh91 avneesh91 mentioned this pull request Dec 8, 2017
Closed
@martijnvg martijnvg self-assigned this Dec 8, 2017
martijnvg
martijnvg requested changes Dec 8, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avneesh91 The paragraph is talking this setting in the context of running tests. So instead of Application, I think it should be Defaults > JUnit?

@jasontedor
Copy link
Copy Markdown
Member

jasontedor commented Dec 8, 2017 •
edited
Loading

For future reference, we do not require an issue to open a PR against (#27716). For a PR like this, a straight PR with no issue is preferred.

@avneesh91
[Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are c…
0fc1747 
…onfusing.

    1. Added the Application to the edit configerations help section for
    IntelliJ.
    2. Added information about how to run a local copy of elasticsearch from
    the source.
@avneesh91 avneesh91 force-pushed the contributing_command_clarification branch from 2b70c43 to 0fc1747 Compare December 8, 2017 11:57
@avneesh91
Copy link
Copy Markdown
Contributor Author

avneesh91 commented Dec 8, 2017

@martijnvg Thanks for reviewing my pull request. Changed the line as per the comment
@jasontedor Closed the issue.

martijnvg
martijnvg approved these changes Dec 8, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avneesh91!

@martijnvg martijnvg merged commit 58b4d6c into elastic:master Dec 8, 2017
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 8, 2017
@jasontedor
Merge branch 'master' into string-split-by-comma
4f05813 
* master:
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
  Test out of order delivery of append only index and retry with an intermediate delete
  [TEST] remove code duplications in RequestTests
  [Tests] Add test for GeoShapeFieldType#setStrategyName (elastic#27703)
  Remove unused *Commit* classes (elastic#27714)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 8, 2017
@jasontedor
Merge branch 'master' into do-not-open-broken-indices
5e9ff4c 
* master: (414 commits)
  Set ACK timeout on indices service test
  Implement byte array reusage in `NioTransport` (elastic#27696)
  [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722)
  Cleanup split strings by comma method
  Remove unused import from AliasResolveRoutingIT
  Add read timeouts to http module (elastic#27713)
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
  Test out of order delivery of append only index and retry with an intermediate delete
  [TEST] remove code duplications in RequestTests
  [Tests] Add test for GeoShapeFieldType#setStrategyName (elastic#27703)
  Remove unused *Commit* classes (elastic#27714)
  Add test for writer operation buffer accounting (elastic#27707)
  [TEST] Wait for merging to complete before testing breaker
  Add Open Index API to the high level REST client (elastic#27574)
  Correcting some minor typos in comments
  Add unreleased v5.6.6 version
  ...
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 9, 2017
@jasontedor
Merge branch 'master' into disable-package-distribution-integ-tests
cbce130 
* master:
  Fix index with unknown setting test
  Remove internal channel tracking in transports (elastic#27711)
  Improve error msg when a field name contains only white spaces (elastic#27709)
  Do not open indices with broken settings
  Set ACK timeout on indices service test
  Implement byte array reusage in `NioTransport` (elastic#27696)
  [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722)
  Cleanup split strings by comma method
  Remove unused import from AliasResolveRoutingIT
  Add read timeouts to http module (elastic#27713)
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
martijnvg pushed a commit that referenced this pull request Dec 20, 2017
@avneesh91 @martijnvg
[Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are c…
c1319d0 
…onfusing. (#27717)

* Improved paragraph describing how to run unit tests from Intellij.
* Added information about how to run a local copy of elasticsearch from the source.
martijnvg added a commit that referenced this pull request Dec 21, 2017
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
c9f1565 
* es/6.x: (43 commits)
  ingest: upgraded ingest geoip's geoip2's dependencies.
  [TEST] logging for update by query test #27820
  Use full profile on JDK 10 builds
  Require Gradle 4.3
  Add unreleased v6.1.2 version
  TEST: reduce blob size #testExecuteMultipartUpload
  Check index under the store metadata lock (#27768)
  Upgrade to Lucene 7.2.0. (#27910)
  Fixed test to be up to date with the new database files.
  Use `_refresh` to shrink the version map on inactivity (#27918)
  Make KeyedLock reentrant (#27920)
  Fixes DocStats to not report index size < -1 (#27863)
  Disable TestZenDiscovery in cloud providers integrations test
  ingest: Upgraded the geolite2 databases.
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (#27717)
  [Test] Fix IndicesClientDocumentationIT (#27899)
  Move uid lock into LiveVersionMap (#27905)
  Mute testRetentionPolicyChangeDuringRecovery
  Increase Gradle heap space to 1536m
  Move GlobalCheckpointTracker and remove SequenceNumbersService (#27837)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

@martijnvg martijnvg

Labels

>docs General docs changes v6.2.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avneesh91 @elasticmachine @jasontedor @martijnvg @colings86