Default to no http read timeout#27879
Merged
Tim-Brooks merged 3 commits intoelastic:masterfrom Dec 19, 2017
Merged
Conversation
Elasticsearch offers a number of http requests that can take a while to execute. In elastic#27713 we introduced an http read timeout that defaulted to 30 seconds. This means that if no reads happened for 30 seconds (even after a request is received), the connection would be closed due to timeout. This commit disables the read timeout by default to allow us to evaluate the impact of read timeouts and to avoid introducing distruptive behavior.
Tim-Brooks
added
:Distributed/Network
s1monw
approved these changes
Dec 19, 2017
|
|
||
| public static final Setting<TimeValue> SETTING_HTTP_READ_TIMEOUT = | ||
| Setting.timeSetting("http.read_timeout", new TimeValue(30, TimeUnit.SECONDS), new TimeValue(0), Property.NodeScope); | ||
| Setting.timeSetting("http.read_timeout", new TimeValue(0), new TimeValue(0), Property.NodeScope); |
Contributor
There was a problem hiding this comment.
can we leave a comment that 0 means no timeout?
Tim-Brooks
added a commit
that referenced
this pull request
Dec 19, 2017
Elasticsearch offers a number of http requests that can take a while to execute. In #27713 we introduced an http read timeout that defaulted to 30 seconds. This means that if no reads happened for 30 seconds (even after a request is received), the connection would be closed due to timeout. This commit disables the read timeout by default to allow us to evaluate the impact of read timeouts and to avoid introducing distruptive behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch offers a number of http requests that can take a while to
execute. In #27713 we introduced an http read timeout that defaulted to
30 seconds. This means that if no reads happened for 30 seconds (even
after a request is received), the connection would be closed due to
timeout.
This commit disables the read timeout by default to allow us to evaluate
the impact of read timeouts and to avoid introducing distruptive
behavior.