Skip to content

Documents applicability of term query to range type#28165

Closed
davidbkemp wants to merge 1 commit intoelastic:masterfrom
davidbkemp:range-type-doc
Closed

Documents applicability of term query to range type#28165
davidbkemp wants to merge 1 commit intoelastic:masterfrom
davidbkemp:range-type-doc

Conversation

@davidbkemp
Copy link
Copy Markdown
Contributor

Addressing #27030

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Jan 10, 2018

Hi @davidbkemp, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@davidbkemp
Copy link
Copy Markdown
Contributor Author

@karmi I accidentally committed that using my work email. I am submitting this as a private individual. Is it OK if I force push that commit using my personal email address?

@davidbkemp
Copy link
Copy Markdown
Contributor Author

I will create a new PR with the correct email address.

@davidbkemp davidbkemp closed this Jan 10, 2018
@davidbkemp davidbkemp deleted the range-type-doc branch January 10, 2018 06:50
@karmi
Copy link
Copy Markdown
Contributor

karmi commented Jan 10, 2018

Hi @davidbkemp, changing the e-mail in Git with git commit --amend --reset-author, and force pushing the branch is completely OK! (Also, it should suffice to just add the other e-mail to your Github profile — can be hidden —, so the Github API can match the e-mail to your profile.)

@davidbkemp
Copy link
Copy Markdown
Contributor Author

Replaced this PR with a new one that has the right email address in the commit. Sorry for the inconvenience. #28166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants