Closed
Conversation
Intellij IDEA's EditorConfig plugin set Continuation Indent the same as `indent_size`. It can be fixed if add `continuation_indent_size` propery.
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
|
@elastic/es-core-infra thoughts on this one? |
Contributor
|
ping @elastic/es-core-infra do we want to get this one in? Thoughts? |
Member
|
Thank you very much for taking the time and addressing this. I have tested this in IntelliJ IDEA 2018.3 (Community Edition), Build #IC-183.4284.148 and the bundled EditorConfig plugin and unfortunately this setting seems to be ineffective. Evidence I am basing my assessment on:
As such I hope you do not mind if we close this PR for the time being as the change is ineffective at the moment. If however, the underlying issue in the IDEA repository is fixed, we can definitely reopen this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent several hours figuring out why Intellij IDEA uses Continuation Indent 4 spaces even if I change size directly in the project settings. Turned out that I had EditorConfig plugin enabled which picks up
.editorconfigand override all the project settings. But the problem is that it sets Continuation Indent the same asindent_size, which is completely wrong. To fix it Plugin's authors added custom propertycontinuation_indent_size. This property is supported only by IDEA but should not bring any harm for other IDEs.