Add an include_type_name option.#29453
Merged
jpountz merged 2 commits intoelastic:masterfrom Apr 11, 2018
Merged
Conversation
This adds an `include_type_name` option to the `indices.create`, `indices.get_mapping` and `indices.put_mapping` APIs, which defaults to `true`. When set to `false`, then mappings will be returned directly in the body of the `indices.get_mapping` API, without keying them by the type name, the `indices.create` will expect mappings directly under the `mappings` key, and the `indices.put_mapping` will use `_doc` as a type name and fail if a `type` is provided explicitly. Relates elastic#15613
jpountz
added
>feature
:Search/Search
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
The documentation and the rest-spec API in this change do not seem to use |
Contributor
|
oh, actually I think I understand now. You mean that the API doesn't reference _doc in this case but the type that is used underneath will be |
Contributor
Author
Correct. I will remove the reference to |
Contributor
Author
|
@colings86 Does it look better? |
colings86
approved these changes
Apr 11, 2018
Contributor
colings86
left a comment
colings86
left a comment
There was a problem hiding this comment.
Yes, I think that its clearer now. This PR LGTM
jpountz
added
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-infra |
jpountz
added
:Core/Infra/REST API
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Jan 4, 2019
This adds an `include_type_name` option to the `indices.create`, `indices.get_mapping` and `indices.put_mapping` APIs, which defaults to `true`. When set to `false`, then mappings will be returned directly in the body of the `indices.get_mapping` API, without keying them by the type name, the `indices.create` will expect mappings directly under the `mappings` key, and the `indices.put_mapping` will use `_doc` as a type name and fail if a `type` is provided explicitly. On 5.x indices, get-mapping will fail if the index has multiple mappings, and put-mapping will update or introduce mappings for the `_doc` type instead of updating existing mappings. This oddity is required so that we don't have to introduce a new flag to put-mapping requests to know whether they are actually updating the `_doc` type or performing a typeless call. Relates elastic#15613
jtibshirani
pushed a commit
that referenced
this pull request
Jan 9, 2019
This adds an `include_type_name` option to the `indices.create`, `indices.get_mapping` and `indices.put_mapping` APIs, which defaults to `true`. When set to `false`, then mappings will be returned directly in the body of the `indices.get_mapping` API, without keying them by the type name, the `indices.create` will expect mappings directly under the `mappings` key, and the `indices.put_mapping` will use `_doc` as a type name and fail if a `type` is provided explicitly. On 5.x indices, get-mapping will fail if the index has multiple mappings, and put-mapping will update or introduce mappings for the `_doc` type instead of updating existing mappings. This oddity is required so that we don't have to introduce a new flag to put-mapping requests to know whether they are actually updating the `_doc` type or performing a typeless call. Relates #15613
This was referenced Jan 9, 2019
jtibshirani
added a commit
that referenced
this pull request
Jan 18, 2019
From #29453 and #37285, the `include_type_name` parameter was already present and defaulted to false. This PR makes the following updates: - Add deprecation warnings to `RestPutMappingAction`, plus tests in `RestPutMappingActionTests`. - Add a typeless 'put mappings' method to the Java HLRC, and deprecate the old typed version. To do this cleanly, I opted to create a new `PutMappingRequest` object that differs from the existing server one.
jtibshirani
added a commit
that referenced
this pull request
Jan 24, 2019
From #29453 and #37285, the include_type_name parameter was already present and defaulted to false. This PR makes the following updates: * Add deprecation warnings to RestCreateIndexAction, plus tests in RestCreateIndexActionTests. * Add a typeless 'create index' method to the Java HLRC, and deprecate the old typed version. To do this cleanly, I created new CreateIndexRequest and CreateIndexResponse objects that differ from the existing server ones.
jtibshirani
added a commit
that referenced
this pull request
Jan 24, 2019
From #29453 and #37285, the include_type_name parameter was already present and defaulted to false. This PR makes the following updates: * Add deprecation warnings to RestCreateIndexAction, plus tests in RestCreateIndexActionTests. * Add a typeless 'create index' method to the Java HLRC, and deprecate the old typed version. To do this cleanly, I created new CreateIndexRequest and CreateIndexResponse objects that differ from the existing server ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
include_type_nameoption to theindices.create,indices.get_mappingandindices.put_mappingAPIs, which defaults totrue.When set to
false, then mappings will be returned directly in the body ofthe
indices.get_mappingAPI, without keying them by the type name, theindices.createwill expect mappings directly under themappingskey, andthe
indices.put_mappingwill use_docas a type name and fail if atypeis provided explicitly.
Relates #15613