Merged
Conversation
Highlighted that you can change shard counts using `_shrink` and `_split`.
dadoonet
approved these changes
Apr 14, 2018
colings86
added
>docs
Collaborator
|
Pinging @elastic/es-core-infra |
colings86
suggested changes
Apr 24, 2018
Contributor
colings86
left a comment
colings86
left a comment
There was a problem hiding this comment.
I think we need to be more careful with the wording here. This changes makes it looks very convenient and easy to change the number of shards on an existing index and so I am worried that users will think that they no longer need to think about how many shards to use before they create the index. In actuality you still need to think about this because changing the shards is not a trivial action and requires that you have a node which has enough free space for 2x the size of thee complete index.
Made it clearer that split/shrink is not trivial and planning is ++
Contributor
|
@colings86 are you ok with the latest commit? |
Contributor
|
retest this please |
Contributor
|
The build failure is totally unrelated, I am going to merge this in. |
javanna
pushed a commit
that referenced
this pull request
Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna
pushed a commit
that referenced
this pull request
Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna
pushed a commit
that referenced
this pull request
Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna
pushed a commit
that referenced
this pull request
Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
jasontedor
added a commit
that referenced
this pull request
Aug 18, 2018
* 6.x: (42 commits) [DOCS] Splits the users API documentation into multiple pages (#32825) [DOCS] Splits the token APIs into separate pages (#32865) [DOCS] Creates redirects for role management APIs page Bypassing failing test PainlessDomainSplitIT#testHRDSplit (#32966) TEST: Mute testRetentionPolicyChangeDuringRecovery [DOCS] Fixes more broken links to role management APIs [Docs] Tweaks and fixes to rollup docs [DOCS] Fixes links to role management APIs [ML][TEST] Fix BasicRenormalizationIT after adding multibucket feature [DOCS] Splits the roles API documentation into multiple pages (#32794) [TEST] Run pre 6.4 nodes in non-FIPS JVMs (#32901) Remove assertion in testDocStats on deletedDocs counter (#32914) [ML] fix updating opened jobs scheduled events (#31651) (#32881) Enable FIPS140LicenseBootstrapCheck (#32903) HLRC: Move ML request converters into their own class (#32906) [DOCS] Update getting-started.asciidoc (#29518) Fix allowed value for HighlighterBuilder encoder in javadocs (#32780) [DOCS] Add "remove a tag" script logic as an example (#32556) RFC: Test that example plugins build stand-alone (#32235) Security: remove put privilege API (#32879) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlighted that you can change shard counts using
_shrinkand_split.