Modify Painless grammar to support right brackets as statement delimiters#29566
Merged
jdconrad merged 3 commits intoelastic:masterfrom Apr 18, 2018
Merged
Modify Painless grammar to support right brackets as statement delimiters#29566jdconrad merged 3 commits intoelastic:masterfrom
jdconrad merged 3 commits intoelastic:masterfrom
Conversation
jdconrad
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
approved these changes
Apr 17, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Neat! I like that you didn't have to change any tests. The change makes sense to me.
Contributor
Author
|
@nik9000 Thanks for the review! Will commit once I can get the CI to pass. |
Contributor
Author
|
@elasticmachine Please test this. |
jdconrad
added a commit
that referenced
this pull request
Apr 18, 2018
This allows the grammar to determine when and what delimiters statements will use by splitting up the statements into regular statements and delimited statements, those that do not require a delimiter versus those that do. This allows consumers of the statements to determine what delimiters the statements will use so that in certain cases semicolons are not necessary like when there's a closing right bracket. This change removes the need for semicolon insertion in the lexer, simplifying the existing lexer quite a bit. It also ensures that there isn't a need to track semicolons being inserted into places that aren't necessary such as array initializers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the grammar to determine when and what delimiters statements will use by splitting up the statements into regular statements and delimited statements, those that do not require a delimiter versus those that do. This allows consumers of the statements to determine what delimiters the statements will use so that in certain cases semicolons are not necessary like when there's a closing right bracket. A little bit of leniency for a little a bit of convenience.
This change removes the need for semicolon insertion in the lexer, simplifying the existing lexer quite a bit. It also ensures that there isn't a need to track semicolons being inserted into places that aren't necessary such as array initializers.
The reason for the large number of lines is due to grammar regeneration. The generated code can be ignored.