CCS: Drop http address from remote cluster info#29568
CCS: Drop http address from remote cluster info#29568nik9000 merged 5 commits intoelastic:masterfrom
Conversation
They are expensive to fetch and no longer needed by Kibana so they *shouldn't* be needed by anyone else either. Closes elastic#29207
nik9000
added
>breaking
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
| connection.getConnectionInfo(actionListener); | ||
| } | ||
| } | ||
| public Stream<RemoteConnectionInfo> getRemoteConnectionInfos() { |
There was a problem hiding this comment.
I'm returning a Stream here because I read https://stackoverflow.com/a/24679745/233833 yesterday. The caller always wants a List but since we have a stream here it seems sane to return the stream and let the caller do what they want with it.
There was a problem hiding this comment.
question: what difference does it make given that the only caller calls toList on this Stream all the time?
There was a problem hiding this comment.
None. I wouldn't go out of my way to return a Stream if I didn't already have one. I just figured, since I do, I may as well return it.
| initialConnectionTimeout = input.readTimeValue(); | ||
| numNodesConnected = input.readVInt(); | ||
| clusterAlias = input.readString(); | ||
| if (input.getVersion().onOrAfter(Version.V_6_1_0)) { |
There was a problem hiding this comment.
I dropped this because I'm not backporting this change to 6.x because it is breaking so I figured this was a good time to remove the bwc for 6.0.x
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeList(seedNodes); |
There was a problem hiding this comment.
I moved this next to the ctor because I like to be able to read the read and write on a single screen if possible.
| assertNotNull(remoteConnectionInfo); | ||
| assertEquals(0, remoteConnectionInfo.numNodesConnected); | ||
| assertEquals(0, remoteConnectionInfo.seedNodes.size()); | ||
| assertEquals(0, remoteConnectionInfo.httpAddresses.size()); |
There was a problem hiding this comment.
We don't have the "give up quickly because we're not connected" behavior any more so we return the list of seed nodes.
|
@elasticmachine, retest this please. |
|
The test failure here is quite real and it is something I'm going to track down. |
The whole point of this is to remove the http address.
…st-variables * origin/master: Test: Switch painless test to 1 shard CCS: Drop http address from remote cluster info (elastic#29568) Reindex: Fold "from old" tests into reindex module (elastic#30142) Convert FieldCapabilitiesResponse to a ToXContentObject. (elastic#30182) [DOCS] Added 'on a single shard' to description of max_thread_count. Closes 28518 (elastic#29686) [TEST] Redirect links to new locations (elastic#30179)
* master: (7173 commits) Bump changelog version to 6.4 (elastic#30217) [DOCS] Adds native realm security settings (elastic#30186) Test: Switch painless test to 1 shard CCS: Drop http address from remote cluster info (elastic#29568) Reindex: Fold "from old" tests into reindex module (elastic#30142) Convert FieldCapabilitiesResponse to a ToXContentObject. (elastic#30182) [DOCS] Added 'on a single shard' to description of max_thread_count. Closes 28518 (elastic#29686) [TEST] Redirect links to new locations (elastic#30179) Move repository-s3 fixture tests to QA test project (elastic#29372) Fail snapshot operations early on repository corruption (elastic#30140) Docs: Document `failures` on reindex and friends Build global ordinals terms bucket from matching ordinals (elastic#30166) Watcher: Ensure mail message ids are unique per watch action (elastic#30112) REST: Remove GET support for clear cache indices (elastic#29525) SQL: Correct error message (elastic#30138) Require acknowledgement to start_trial license (elastic#30135) Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (elastic#30181) SQL: Add BinaryMathProcessor to named writeables list (elastic#30127) Tests: Use buildDir as base for generated-resources (elastic#30191) Fix SliceBuilderTests#testRandom failures ...
4 participants
They are expensive to fetch and no longer needed by Kibana so they
shouldn't be needed by anyone else either.
Closes #29207