Merged
Conversation
lcawl
reviewed
Apr 30, 2018
docs/CHANGELOG.asciidoc
Outdated
|
|
||
| <<write-thread-pool-fallback, Removed `thread_pool.bulk.*` settings and | ||
| `es.thread_pool.write.use_bulk_as_display_name` system property>> ({pull}29609[#29609]) | ||
| write-thread-pool-fallback, Removed `thread_pool.bulk.*` settings and |
Contributor
There was a problem hiding this comment.
Is this supposed to be a link to https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_70_settings_changes.html#write-thread-pool-fallback ?
jasontedor
reviewed
Apr 30, 2018
docs/CHANGELOG.asciidoc
Outdated
|
|
||
| <<write-thread-pool-fallback, Removed `thread_pool.bulk.*` settings and | ||
| `es.thread_pool.write.use_bulk_as_display_name` system property>> ({pull}29609[#29609]) | ||
| write-thread-pool-fallback, Removed `thread_pool.bulk.*` settings and |
Member
There was a problem hiding this comment.
This edit is wrong. This is a link, hence <<,>>.
jasontedor
requested changes
Apr 30, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
The edits to the cross-doc links are not right.
This reverts commit 385f2fa.
Contributor
Author
|
@jasontedor I reverted the incorrect changes, thanks for the catch! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 1, 2018
* origin/master: [test] add java packaging test project (elastic#30161) Fix macros in changelog (elastic#30269) [DOCS] Fixes syskeygen command name [ML] Include 3rd party C++ component notices (elastic#30132) _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264) Improve docs for disk watermarks (elastic#30249) [DOCS] Removes redundant Active Directory realm settings (elastic#30190) [DOCS] Removes redundant LDAP realm settings (elastic#30193) _cluster/state should always return cluster_uuid (elastic#30143) HTML5ify Javadoc for core and test framework (elastic#30234) Minor tweaks to reroute documentation (elastic#30246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had mistakenly commented out two helpful macros for the changelog, which caused the generated docs not to look correct. This PR fixes linking to issues and pull requests with
:link:and:pull:Steps I took to test this PR:
if necessary,
git clone git@github.com:elastic/docs.gitand install appropriate perl stuffs, we'll be using thebuild_docs.plscript.from
elasticsearchdir, runperl ../docs/build_docs.pl --doc docs/CHANGELOG.asciidoc --open --lenient. This should open up a browser linking you to localhostconfirm pull request links show up correctly, etc.
Before:
After: