Skip to content

Client: Deprecate many argument performRequest#30315

Merged
nik9000 merged 6 commits intoelastic:masterfrom
nik9000:rest_deprecate_orignal_requests
May 8, 2018
Merged

Client: Deprecate many argument performRequest#30315
nik9000 merged 6 commits intoelastic:masterfrom
nik9000:rest_deprecate_orignal_requests

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented May 1, 2018

Deprecate the many arguments versions of performRequest and
performRequestAsync in favor of the Request object flavored variants
introduced in #29623. We'll be dropping the many arguments variants in
7.0 because they make it difficult to add new features in a backwards
compatible way and they create a ton of intellisense noise.

@nik9000
Client: Deprecate many argument performRequest
6a7fc4e 
Deprecate the many arguments versions of `performRequest` and
`performRequestAsync` in favor of the `Request` object flavored variants
introduced in elastic#29623. We'll be dropping the many arguments variants in
7.0 because they make it difficult to add new features in a backwards
compatible way and they create a *ton* of intellisense noise.
@nik9000 nik9000 added review >deprecation :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch v7.0.0 v6.4.0 labels May 1, 2018
@nik9000 nik9000 requested a review from javanna May 1, 2018 20:58
@hub-cap hub-cap added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch and removed :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch labels May 3, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented May 3, 2018

Pinging @elastic/es-core-infra

javanna
javanna approved these changes May 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a small typo, LGTM otherwise

docs/CHANGELOG.asciidoc Outdated
=== Deprecation

Deprecated multi-argument versions of the request methods in the RestClient.
Prefer the "Request" object falvored methods. ({pull}30315[#30315])
Copy link
Copy Markdown
Contributor

@javanna javanna May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/falvored/flavored

@nik9000 nik9000 merged commit b062ce5 into elastic:master May 8, 2018
nik9000 added a commit that referenced this pull request May 8, 2018
@nik9000
Client: Deprecate many argument performRequest (#30315)
2837d8f 
Deprecate the many arguments versions of `performRequest` and
`performRequestAsync` in favor of the `Request` object flavored variants
introduced in #29623. We'll be dropping the many arguments variants in
7.0 because they make it difficult to add new features in a backwards
compatible way and they create a *ton* of intellisense noise.
@nik9000
Copy link
Copy Markdown
Member Author

nik9000 commented May 8, 2018

Thanks for reviewing @javanna ! I've merged and backported.

dnhatn added a commit that referenced this pull request May 8, 2018
@dnhatn
Merge branch 'master' into ccr
5d99157 
* master:
  Mute ML upgrade test (#30458)
  Stop forking javac (#30462)
  Client: Deprecate many argument performRequest (#30315)
  Docs: Use task_id in examples of tasks (#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (#30442)
  [Docs] Fix typo in cardinality-aggregation.asciidoc (#30434)
  Avoid NPE in `more_like_this` when field has zero tokens (#30365)
  Build: Switch to building javadoc with html5 (#30440)
  Add a quick tour of the project to CONTRIBUTING (#30187)
  Reindex: Use request flavored methods (#30317)
  Silence SplitIndexIT.testSplitIndexPrimaryTerm test failure. (#30432)
  Auto-expand replicas when adding or removing nodes (#30423)
  Docs: fix changelog merge
  Fix line length violation in cache tests
  Add stricter geohash parsing (#30376)
  Add failing test for core cache deadlock
  [DOCS] convert forcemerge snippet
  Update forcemerge.asciidoc (#30113)
  Added zentity to the list of API extension plugins (#29143)
  Fix the search request default operation behavior doc (#29302) (#29405)
dnhatn added a commit that referenced this pull request May 8, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
a3340d6 
* 6.x:
  Client: Deprecate many argument performRequest (#30315)
  Mute ML upgrade test (#30458)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 9, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into cache-deadlock
a3e152f 
* elastic/master:
  Mute ML upgrade test (elastic#30458)
  Stop forking javac (elastic#30462)
  Client: Deprecate many argument performRequest (elastic#30315)
  Docs: Use task_id in examples of tasks (elastic#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (elastic#30442)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 9, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into no-copy-settings-f…
030a3e9 
…or-you

* elastic/master: (22 commits)
  Docs: Test examples that recreate lang analyzers  (elastic#29535)
  BulkProcessor to retry based on status code (elastic#29329)
  Add GET Repository High Level REST API (elastic#30362)
  add a comment explaining the need for RetryOnReplicaException on missing mappings
  Add `coordinating_only` node selector (elastic#30313)
  Stop forking groovyc (elastic#30471)
  Avoid setting connection request timeout (elastic#30384)
  Use date format in `date_range` mapping before fallback to default (elastic#29310)
  Watcher: Increase HttpClient parallel sent requests (elastic#30130)
  Mute ML upgrade test (elastic#30458)
  Stop forking javac (elastic#30462)
  Client: Deprecate many argument performRequest (elastic#30315)
  Docs: Use task_id in examples of tasks (elastic#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (elastic#30442)
  [Docs] Fix typo in cardinality-aggregation.asciidoc (elastic#30434)
  Avoid NPE in `more_like_this` when field has zero tokens (elastic#30365)
  Build: Switch to building javadoc with html5 (elastic#30440)
  Add a quick tour of the project to CONTRIBUTING (elastic#30187)
  Reindex: Use request flavored methods (elastic#30317)
  Silence SplitIndexIT.testSplitIndexPrimaryTerm test failure. (elastic#30432)
  ...
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request May 14, 2018
@nik9000
Switch many QA projects to use new style requests
9329a5a 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the the old requests. This
changes many calls in the `qa` projects to use the new version.
@nik9000 nik9000 mentioned this pull request May 14, 2018
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request May 14, 2018
@nik9000
Switch distribution to new style Requests
3d15677 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `distribution/archives/integ-test-zip` project
to use the new versions.
@nik9000 nik9000 mentioned this pull request May 14, 2018
Merged
nik9000 added a commit that referenced this pull request May 15, 2018
@nik9000
Switch many QA projects to use new style requests (#30574)
6695d11 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the the old requests. This
changes many calls in the `qa` projects to use the new version.
nik9000 added a commit that referenced this pull request May 16, 2018
@nik9000
Switch many QA projects to use new style requests (#30574)
c350c22 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the the old requests. This
changes many calls in the `qa` projects to use the new version.
nik9000 added a commit that referenced this pull request Jul 10, 2018
@nik9000
Switch high level rest tests to new style requests
71ebee3 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `client/rest-high-level` project to use the new
versions.
nik9000 added a commit that referenced this pull request Jul 23, 2018
@nik9000
Switch x-pack:core to new style Requests (#32252)
4804da0 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:core` project to use the new versions.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 23, 2018
@nik9000
Switch x-pack full restart to new style Requests
2fcf530 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:qa:full-cluster-restart` project to use
the new versions.
@nik9000 nik9000 mentioned this pull request Jul 23, 2018
Merged
nik9000 added a commit that referenced this pull request Jul 23, 2018
@nik9000
Switch x-pack:core to new style Requests (#32252)
ad4bbb1 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:core` project to use the new versions.
nik9000 added a commit that referenced this pull request Jul 23, 2018
@nik9000
Switch monitoring to new style Requests (#32255)
55a2d3e 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin/monitoring` project to use the new
versions.
nik9000 added a commit that referenced this pull request Jul 23, 2018
@nik9000
Switch monitoring to new style Requests (#32255)
f45b17d 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin/monitoring` project to use the new
versions.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 24, 2018
@nik9000
Switch x-pack/plugin to new style Requests
5d8b48b 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin` project to use the new versions.
@nik9000 nik9000 mentioned this pull request Jul 24, 2018
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 24, 2018
@nik9000
Switch x-pack rolling restart to new style Requests
e5c5371 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:qa:rolling-upgrade*` projects to use
the new versions.
@nik9000 nik9000 mentioned this pull request Jul 24, 2018
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 24, 2018
@nik9000
Switch security spi example to new style Requests
710daf9 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/security-example-spi-extension`
project to use the new versions.
@nik9000 nik9000 mentioned this pull request Jul 24, 2018
Merged
nik9000 added a commit that referenced this pull request Jul 26, 2018
@nik9000
Switch x-pack full restart to new style Requests (#32294)
11a2189 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:qa:full-cluster-restart` project to use
the new versions.
nik9000 added a commit that referenced this pull request Jul 26, 2018
@nik9000
Switch x-pack full restart to new style Requests (#32294)
12cf0fd 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack:qa:full-cluster-restart` project to use
the new versions.
nik9000 added a commit that referenced this pull request Jul 26, 2018
@nik9000
Switch x-pack/plugin to new style Requests (#32327)
643235d 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin` project to use the new versions.
nik9000 added a commit that referenced this pull request Jul 26, 2018
@nik9000
Switch x-pack/plugin to new style Requests (#32327)
3e217dc 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin` project to use the new versions.
nik9000 added a commit that referenced this pull request Jul 30, 2018
@nik9000
Switch security spi example to new style Requests (#32341)
6706309 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/security-example-spi-extension`
project to use the new versions.
nik9000 added a commit that referenced this pull request Jul 30, 2018
@nik9000
Switch security spi example to new style Requests (#32341)
0e3c799 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/security-example-spi-extension`
project to use the new versions.
nik9000 added a commit that referenced this pull request Jul 30, 2018
@nik9000
Switch security to new style Requests (#32290)
4101fc4 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin/security` project to use the new
versions.
nik9000 added a commit that referenced this pull request Jul 31, 2018
@nik9000
Switch security to new style Requests (#32290)
7bc61f8 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/plugin/security` project to use the new
versions.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 31, 2018
@nik9000
Switch ml basic tests to new style Requests
fde9f40 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/ml-basic-multi-node` project to use
the new versions.
@nik9000 nik9000 mentioned this pull request Jul 31, 2018
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 31, 2018
@nik9000
Switch some x-pack tests to new style Requests
f500262 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/audit-tests`,
`x-pack/qa/ml-disabled`, and `x-pack/qa/multi-node` projects to use the
new versions.
@nik9000 nik9000 mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 21, 2018
Merged
Merged
Merged
Merged
Merged
@nik9000 nik9000 mentioned this pull request Aug 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@javanna javanna javanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >deprecation v6.4.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nik9000 @elasticmachine @javanna @hub-cap @jimczi