Docs: Document how to rebuild analyzers#30498
Merged
nik9000 merged 5 commits intoelastic:masterfrom May 14, 2018
Merged
Conversation
Adds documentation for how to rebuild all the built in analyzers and tests for that documentation using the mechanism added in elastic#29535. Closes elastic#29499
nik9000
added
>docs
Collaborator
|
Pinging @elastic/es-search-aggs |
mayya-sharipova
approved these changes
May 14, 2018
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
LGTM except some small minor changes
| recreate it as a `custom` analyzer and modify it, usually by adding | ||
| token filters. Usually, you should prefer the | ||
| <<keyword, Keyword type>> when you want strings that are not split | ||
| into tokens, but just in case you need it, this his would recreate |
Contributor
There was a problem hiding this comment.
"this his" -> "this" ?
| "tokenizer": { | ||
| "split_on_non_word": { | ||
| "type": "pattern", | ||
| "stopwords": "\\W+" <1> |
Contributor
There was a problem hiding this comment.
should it be pattern instead of stopwords?
Member
Author
There was a problem hiding this comment.
Yes! Now I have to figure out how the tests passed when it was wrong....
Member
Author
There was a problem hiding this comment.
I believe it is because \\W+ is the default. And because we don't complain if you pass extra stuff here.
| [float] | ||
| === Definition | ||
|
|
||
| The `simple` anlzyer consists of: |
Contributor
There was a problem hiding this comment.
"anlzyer" -> "analyzer"
|
|
||
| If you need to customize the `pattern` analyzer beyond the configuration | ||
| parameters then you need to recreate it as a `custom` analyzer and modify | ||
| it, usually by adding token filters. This would recreate the built in |
Contributor
There was a problem hiding this comment.
"built in" -> "built-in"
in this place and in all other places
nik9000
added a commit
that referenced
this pull request
May 14, 2018
Member
Author
|
Thanks @mayya-sharipova! I've fixed it up as you requested and merged and backported. |
dnhatn
added a commit
that referenced
this pull request
May 15, 2018
* 6.x: Revert "Silence IndexUpgradeIT test failures. (#30430)" [DOCS] Remove references to changelog and to highlights Revert "Mute ML upgrade test (#30458)" [ML] Fix BWC version for backport of #30125 [Docs] Improve section detailing translog usage (#30573) [Tests] Relax allowed delta in extended_stats aggregation (#30569) Fail if reading from closed KeyStoreWrapper (#30394) [ML] Reverse engineer Grok patterns from categorization results (#30125) Derive max composite buffers from max content len Update build file due to doc file rename SQL: Extract SQL request and response classes (#30457) Remove the changelog (#30593) Revert "Add deprecation warning for default shards (#30587)" Silence IndexUpgradeIT test failures. (#30430) Add deprecation warning for default shards (#30587) [DOCS] Adds 6.4.0 release highlight pages [DOCS] Adds release highlight pages (#30590) Docs: Document how to rebuild analyzers (#30498) [DOCS] Fixes title capitalization in security content LLRest: Add equals and hashcode tests for Request (#30584) [DOCS] Fix realm setting names (#30499) [DOCS] Fix path info for various security files (#30502) Docs: document precision limitations of geo_bounding_box (#30540) Fix non existing javadocs link in RestClientTests Auto-expand replicas only after failing nodes (#30553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for how to rebuild all the built in analyzers and
tests for that documentation using the mechanism added in #29535.
Closes #29499