Store the reason of noop in its document tombstone#30570
Merged
dnhatn merged 4 commits intoelastic:ccrfrom May 15, 2018
Merged
Conversation
dnhatn
added
>feature
:Distributed/Engine
Collaborator
|
Pinging @elastic/es-distributed |
s1monw
reviewed
May 14, 2018
| final ParsedDocument tombstone = engineConfig.getTombstoneDocSupplier().newNoopTombstoneDoc(); | ||
| final BytesReference reason = BytesReference.bytes( | ||
| JsonXContent.contentBuilder().startObject().field(NoOp.REASON_FIELD_NAME, noOp.reason()).endObject()); | ||
| final ParsedDocument tombstone = engineConfig.getTombstoneDocSupplier().newNoopTombstoneDoc(reason); |
Contributor
There was a problem hiding this comment.
can't we use a simple stored field? I mean do we have to store json?
Member
Author
|
@s1monw I tried to keep _source in JSON format as other docs but it was not necessary. I've updated the PR to store the reason in a raw string. Can you please have a look? |
s1monw
approved these changes
May 14, 2018
Member
Author
|
@elasticmachine test this please |
bleskes
reviewed
May 15, 2018
| final SourceToParse sourceToParse = SourceToParse.source(index, type, id, new BytesArray("{}"), XContentType.JSON); | ||
| final ParsedDocument parsedDoc = documentParser.parseDocument(sourceToParse, noopTombstoneMetadataFieldMappers).toTombstone(); | ||
| // Store the reason of a noop as a raw string in the _source field | ||
| final BytesRef byteRef = new BytesRef(reason); |
Contributor
There was a problem hiding this comment.
I'm doubting about this - should we always make it valid JSON : { "_reason": "bla" } ? I think it might surprising to find non json in the source field.
bleskes
reviewed
May 15, 2018
Contributor
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
I raised a simple issue to discuss.
Member
Author
Contributor
|
I don't mind much. If Simon prefers a string, I'm good. |
bleskes
approved these changes
May 15, 2018
Member
Author
|
@elasticmachine test this please |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #29530