Add Delete Snapshot High Level REST API#31393
Add Delete Snapshot High Level REST API#31393danielmitterdorfer merged 6 commits intoelastic:masterfrom
Conversation
With this commit we add the delete snapshot API to the Java high level REST client. Relates elastic#27205
|
Pinging @elastic/es-core-infra |
|
@danielmitterdorfer you can use the low level rest API in the tests, and then change them once the high level API is done. This is what I did when implementing |
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
This is a great PR, quite nice to review. Just fyi, running the doc build shows that there are failures to the docs. LGTM for the most part, once the test is impl'd and the docs build is fixed.
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left a small comment as well
| * @return the response | ||
| * @throws IOException in case there is a problem sending the request or parsing back the response | ||
| */ | ||
| public DeleteSnapshotResponse deleteSnapshot(DeleteSnapshotRequest deleteSnapshotRequest, RequestOptions options) throws IOException { |
There was a problem hiding this comment.
can you call these methods delete without the snapshot part? they will be called as client.snapshot().delete() then which is how they are defined in our SPEC
There was a problem hiding this comment.
Makes sense. I've changed it.
|
@hub-cap I've implemented the tests now based on the low-level client as per your suggestion and fixed the doc issues. Can you please have another look? |
|
Doh that was supposed to be a |
not a 🚢
|
Both icons work for me. ;) Thanks for the review! |
|
Backported to 6.x in 71b3ac2. |
5 participants
With this commit we add the delete snapshot API to the Java high level
REST client.
Relates #27205