Docs: Add note about removing prepareExecute from the java client#31401
Merged
rjernst merged 2 commits intoelastic:masterfrom Jun 19, 2018
Merged
Docs: Add note about removing prepareExecute from the java client#31401rjernst merged 2 commits intoelastic:masterfrom
rjernst merged 2 commits intoelastic:masterfrom
Conversation
rjernst
added
>docs
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@elasticmachine run gradle build tests |
cbuescher
reviewed
Jun 18, 2018
| ==== `prepareExecute` removed from the client api | ||
|
|
||
| The `prepareExecute` method which created a request builder has been | ||
| removed from the client api. Instead, construct a build for the |
Member
There was a problem hiding this comment.
not sure if this should be "builder" here
Member
Author
There was a problem hiding this comment.
The prepareExecute method returned a RequestBuilder. Is there something else you think it should be?
Member
Author
There was a problem hiding this comment.
Oops, I see what you mean, thanks!
Contributor
|
thanks @rjernst ! This was mainly used by modules and plugins given that for the methods supported by default we still have the prepare* methods around, right? That's what confused me in the original PR, maybe worth mentioning. |
javanna
approved these changes
Jun 19, 2018
Member
Author
|
I think it would be confusing to mention the other |
Contributor
|
I didn't mean to mention unchanged bits, rather to explain clearly who may be impacted by this change (plugins devs rather than users) |
dnhatn
added a commit
that referenced
this pull request
Jun 20, 2018
* master: [DOCS] Omit shard failures assertion for incompatible responses (#31430) [DOCS] Move licensing APIs to docs (#31445) Add Delete Snapshot High Level REST API Remove QueryCachingPolicy#ALWAYS_CACHE (#31451) [Docs] Extend Homebrew installation instructions (#28902) Choose JVM options ergonomically [Docs] Mention ip_range datatypes on ip type page (#31416) Multiplexing token filter (#31208) Fix use of time zone in date_histogram rewrite (#31407) Core: Remove index name resolver from base TransportAction (#31002) [DOCS] Fixes code snippet testing for machine learning (#31189) [DOCS] Removed and params from MLT. Closes #28128 (#31370) Security: fix joining cluster with production license (#31341) Unify http channels and exception handling (#31379) [DOCS] Moves the info API to docs (#31121) Preserve response headers on cluster update task (#31421) [DOCS] Add code snippet testing for more ML APIs (#31404) Do not preallocate bytes for channel buffer (#31400) Docs: Advice for reindexing many indices (#31279) Mute HttpExporterTests#testHttpExporterShutdown test Tracked by #31433 Docs: Add note about removing prepareExecute from the java client (#31401) Make release notes ignore the `>test-failure` label. (#31309)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #30966