Do not add multiple copies of stale docs to Lucene#31806
Closed
dnhatn wants to merge 1 commit intoelastic:ccrfrom
Closed
Do not add multiple copies of stale docs to Lucene#31806dnhatn wants to merge 1 commit intoelastic:ccrfrom
dnhatn wants to merge 1 commit intoelastic:ccrfrom
Conversation
Since elastic#29679 we started adding stale operations to Lucene to have a complete history in Lucene. As the stale docs are rare, we accepted to have duplicate copies of them to keep an engine simple. However, we now need to make sure that we have a single copy per stale operation in Lucene because the Lucene rollback requires a single document for each sequence number.
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
@bleskes This PR is to deal with the duplicated - nested documents. The rollback won't be correct without this deduplication logic in the following scenario.
|
Contributor
|
we discussed this via another channel and agreed we need to spend some thought on whether this is needed. |
Member
|
@dnhatn I think that we can close this PR for now? |
Member
Author
|
@jasontedor Thanks for the ping. Yes, I should have closed it. I am closing this as we are going to implement a commit-based rollback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #29679 we started adding stale operations to Lucene to have a complete history in Lucene. As the stale docs are rare, we accepted to have duplicate copies of them to keep an engine simple.
However, we now need to make sure that we have a single copy per stale operation in Lucene because the Lucene rollback requires a single document for each sequence number.
Relates #31637