Convert Version to Java - clusterformation part1#32009
Merged
alpar-t merged 3 commits intoelastic:masterfrom Jul 13, 2018
Merged
Convert Version to Java - clusterformation part1#32009alpar-t merged 3 commits intoelastic:masterfrom
alpar-t merged 3 commits intoelastic:masterfrom
Conversation
- This allows to move all all .java files from .groovy. - Will prevent eclipse from tangling up in this setup - make it possible to use Version from Java
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Awesome, thanks so much for doing this ❤️ |
rjernst
approved these changes
Jul 12, 2018
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks good. I left some minor requests, if you agree no further need for review.
| return Objects.hash(major, minor, revision, id, snapshot, suffix); | ||
| } | ||
|
|
||
| public final int getMajor() { |
Member
There was a problem hiding this comment.
I would make the class final, and these members public final
| return snapshot; | ||
| } | ||
|
|
||
| public final boolean isSnapshot() { |
Member
There was a problem hiding this comment.
Why do you have get and is? If we don't make these public final members, then at least there should only be one of these methods.
Contributor
Author
There was a problem hiding this comment.
It's just an oversight. I'm removing get
| } | ||
| if (rootPathList == null) { | ||
| fail("No paths provided"); | ||
| return; |
Member
There was a problem hiding this comment.
There should be no need for a return here since fail throws an exception.
Contributor
Author
There was a problem hiding this comment.
It calls System.exit which is not picked up and IDE complains below that rootPathList might be null.
| Version.fromString("5.3.0"), Version.fromString("5.3.1")] | ||
|
|
||
| assertTrue(wireCompatList.containsAll(vc.wireCompatible)) | ||
| def compatible = vc.wireCompatible |
Member
There was a problem hiding this comment.
Please use a concrete type, eg List
alpar-t
added a commit
that referenced
this pull request
Jul 18, 2018
Implement buildSrc Version in java - This allows to move all all .java files from .groovy. - Will prevent eclipse from tangling up in this setup - make it possible to use Version from Java This backport pulls in some changes from the non backported #27397 but that should be fine
dnhatn
added a commit
that referenced
this pull request
Jul 19, 2018
* 6.x: Fix rollup on date fields that don't support epoch_millis (#31890) Revert "Introduce a Hashing Processor (#31087)" (#32179) [test] use randomized runner in packaging tests (#32109) Painless: Fix caching bug and clean up addPainlessClass. (#32142) Fix BwC Tests looking for UUID Pre 6.4 (#32158) (#32169) Call setReferences() on custom referring tokenfilters in _analyze (#32157) Add more contexts to painless execute api (#30511) Add EC2 credential test for repository-s3 (#31918) Fix CP for namingConventions when gradle home has spaces (#31914) Convert Version to Java - clusterformation part1 (#32009) Fix Java 11 javadoc compile problem Improve docs for search preferences (#32098) Configurable password hashing algorithm/cost(#31234) (#32092) [DOCS] Update TLS on Docker for 6.3 ESIndexLevelReplicationTestCase doesn't support replicated failures but it's good to know what they are Switch distribution to new style Requests (#30595) Build: Skip jar tests if jar disabled Build: Move shadow customizations into common code (#32014) Painless: Add PainlessClassBuilder (#32141) Fix accidental duplication of bwc test for script behavior Handle missing values in painless (#30975) (#31903) Build: Make additional test deps of check (#32015) Painless: Fix Bug with Duplicate PainlessClasses (#32110) Adjust translog after versionType removed in 7.0 (#32020) Disable C2 from using AVX-512 on JDK 10 (#32138) [Rollup] Add new capabilities endpoint for concrete rollup indices (#32111) Mute :qa:mixed-cluster indices.stats/10_index/Index - all’ [ML] Wait for aliases in multi-node tests (#32086) Ensure to release translog snapshot in primary-replica resync (#32045) Docs: Fix missing example script quote (#32010) Add Index UUID to `/_stats` Response (#31871) (#32113) [ML] Move analyzer dependencies out of categorization config (#32123) [ML][DOCS] Add missing 6.3.0 release notes (#32099) Updates the build to gradle 4.9 (#32087) Update monitoring template version to 6040099 (#32088) Fix put mappings java API documentation (#31955) Add exclusion option to `keep_types` token filter (#32012)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no change in functionality.
There are also some additional tests for Version.