Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine run sample packaging tests |
imotov
approved these changes
Jul 16, 2018
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
LGTM
@ahmedakef in the future, could you please open PRs against master instead of other branches (in this case 6.3) and provide a better commit description.
imotov
pushed a commit
that referenced
this pull request
Jul 16, 2018
Provides a more precise equivalent SQL query for the aggregation example in the getting started guide.
imotov
pushed a commit
that referenced
this pull request
Jul 16, 2018
Provides a more precise equivalent SQL query for the aggregation example in the getting started guide.
martijnvg
added a commit
that referenced
this pull request
Jul 17, 2018
* es/6.x: Scripting: Remove dead code from painless module (#32064) (#32104) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Core: Backport java time date formatters (#31997) Switch non-x-pack to new style requests (#32106) SQL: allow LEFT and RIGHT as function names (#32066) Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054) [test] turn on host io cache for opensuse (#32053) DOCS: put LIMIT 10 to the SQL query (#32065)
martijnvg
added a commit
that referenced
this pull request
Jul 17, 2018
* es/master: Add Index UUID to `/_stats` Response (#31871) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Switch non-x-pack to new style requests (#32106) [Rollup] Add new capabilities endpoint for concrete rollup indices (#30401) Revert "[test] disable packaging tests for suse boxes" SQL: allow LEFT and RIGHT as function names (#32066) DOCS: put LIMIT 10 to the SQL query (#32065) [test] turn on host io cache for opensuse (#32053) Tweaked Elasticsearch Service links for SEO
Contributor
Author
|
@imotov Thanks, I will consider that in the future ISA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle check?