Scripting: Cleanup todo in BucketSelectorPipelineAggregator#32134
Closed
original-brownbear wants to merge 1 commit intoelastic:masterfrom
original-brownbear:cleanup-todo-bucketselectorpipelineaggregator
Closed
Scripting: Cleanup todo in BucketSelectorPipelineAggregator#32134original-brownbear wants to merge 1 commit intoelastic:masterfrom original-brownbear:cleanup-todo-bucketselectorpipelineaggregator
BucketSelectorPipelineAggregator#32134original-brownbear wants to merge 1 commit intoelastic:masterfrom
original-brownbear:cleanup-todo-bucketselectorpipelineaggregator
Conversation
* Make all fields that are effectively `final` actually `final` * Exploit the fact that `script` is `final` to build the keepBucket logic at construction time to avoid redundant condition in the loop
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
Author
|
Jenkins test this |
Contributor
Author
|
@cbuescher thanks for the review! Unfortunately this was superseded by #32068 |
original-brownbear
deleted the
cleanup-todo-bucketselectorpipelineaggregator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalactuallyfinalscriptisfinalto build the keepBucket logic at construction time to avoid redundant condition in the loopjust a random thing I found when working on #32068 ... the todo wasn't terribly actionable but I think this makes the situation a little nicer at least :)