Skip to content

INGEST: Add Configuration Except. Data to Metdata#32322

Merged
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:27728
Aug 15, 2018
Merged

INGEST: Add Configuration Except. Data to Metdata#32322
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:27728

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@talevy can you take a look here? I'm only 80% this is what we're looking for here functionally tbh. :)

@talevy
Copy link
Copy Markdown
Contributor

talevy commented Aug 14, 2018

oh woah, apologies for missing this @original-brownbear. changes look good. I think we should tag this as breaking? Although it is a super esoteric part of the response body, some users may be depending on it

Copy link
Copy Markdown
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@talevy No worries, this really was low priority :) + yea makes sense, tagged as breaking.
Merging in master since it's been a while since I opened this one and will merge once green :)

@original-brownbear original-brownbear merged commit 986c55b into elastic:master Aug 15, 2018
@original-brownbear original-brownbear deleted the 27728 branch August 15, 2018 17:02
jasontedor added a commit that referenced this pull request Aug 15, 2018
* master:
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (#32860)
  [ML] Add log structure finder functionality (#32788)
  INGEST: Add Configuration Except. Data to Metdata (#32322)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 24, 2018
…-checkpoint-poll

* 'master' of github.com:elastic/elasticsearch:
  Fix docs for fixed filename for heap dump path (elastic#32882)
  Painless: Special Case def (elastic#32871)
  AwaitFix FullClusterRestartIT#testRollupIDSchemeAfterRestart.
  [Test] Fix DuelScrollIT#testDuelIndexOrderQueryThenFetch
  HLRC: adding machine learning delete job (elastic#32820)
  [DOCS] Update WordPress plugins links (elastic#32194)
  Remove passphrase support from reload settings API (elastic#32889)
  AwaitFix AckIT.
  Mutes test in DuelScrollIT
  CharArraysTests: Fix test bug.
  [ML] Choose seconds to fix intermittent DatafeeedConfigTest failure
  Test: Fix unpredictive merges in DocumentSubsetReaderTests
  [DOCS] Clarify sentence in network-host.asciidoc (elastic#32429)
  Docs enhancement: added reference to cluster-level setting `search.default_allow_partial_results` (elastic#32810)
  [DOCS] Fixing cross doc link to Stack Overview security topic.
  Move CharArrays to core lib (elastic#32851)
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (elastic#32860)
  [ML] Add log structure finder functionality (elastic#32788)
  INGEST: Add Configuration Except. Data to Metdata (elastic#32322)
@lcawl lcawl mentioned this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metadata to configuration exceptions

4 participants