Core: Add java time version of rounding classes#32641
Merged
spinscale merged 12 commits intoelastic:masterfrom Aug 14, 2018
Merged
Core: Add java time version of rounding classes#32641spinscale merged 12 commits intoelastic:masterfrom
spinscale merged 12 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
spinscale
force-pushed
the
1807-java-time-port-roundingtime
branch
from
3f17d9b to
8851336
Compare
rjernst
approved these changes
Aug 8, 2018
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks ok. It is difficult to review since it is mostly a copy of existing code. There are things I would like to have improved (eg adding java docs or not having the streams code be so indirect), but those are problems with the existing code. I reviewed the key methods using java 8 time apis as well as I could.
| /** | ||
| * A strategy for rounding long values. | ||
| */ | ||
| public abstract class Rounding implements Writeable { |
Member
There was a problem hiding this comment.
Can we use a different class name and not put these into their own package? Once we drop joda time, we can rename these type of java time versions back to their original name. By using the same name, it makes opening a class by name in IntelliJ more difficult.
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * A strategy for rounding long values. |
Member
There was a problem hiding this comment.
Can you add a deprecation annotation to the joda based round class?
…e deleted when joda time gets removed
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2018
…e-types * elastic/master: (199 commits) Watcher: Remove unused hipchat render method (elastic#32211) Watcher: Remove extraneous auth classes (elastic#32300) Watcher: migrate PagerDuty v1 events API to v2 API (elastic#32285) [TEST] Select free port for Minio (elastic#32837) MINOR: Remove `IndexTemplateFilter` (elastic#32841) Core: Add java time version of rounding classes (elastic#32641) Aggregations/HL Rest client fix: missing scores (elastic#32774) HLRC: Add Delete License API (elastic#32586) INGEST: Create Index Before Pipeline Execute (elastic#32786) Fix NOOP bulk updates (elastic#32819) Remove client connections from TcpTransport (elastic#31886) Increase logging testRetentionPolicyChangeDuringRecovery AwaitsFix case-functions.sql-spec Mute security-cli tests in FIPS JVM (elastic#32812) SCRIPTING: Support BucketAggScript return null (elastic#32811) Unmute WildFly tests in FIPS JVM (elastic#32814) [TEST] Force a stop to save rollup state before continuing (elastic#32787) [test] disable packaging tests for suse boxes Mute IndicesRequestIT#testBulk [ML][DOCS] Refer to rules feature as custom rules (elastic#32785) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2018
…listeners * elastic/master: Watcher: Remove unused hipchat render method (elastic#32211) Watcher: Remove extraneous auth classes (elastic#32300) Watcher: migrate PagerDuty v1 events API to v2 API (elastic#32285) [TEST] Select free port for Minio (elastic#32837) MINOR: Remove `IndexTemplateFilter` (elastic#32841) Core: Add java time version of rounding classes (elastic#32641) Aggregations/HL Rest client fix: missing scores (elastic#32774) HLRC: Add Delete License API (elastic#32586) INGEST: Create Index Before Pipeline Execute (elastic#32786) Fix NOOP bulk updates (elastic#32819) Remove client connections from TcpTransport (elastic#31886) Increase logging testRetentionPolicyChangeDuringRecovery AwaitsFix case-functions.sql-spec Mute security-cli tests in FIPS JVM (elastic#32812) SCRIPTING: Support BucketAggScript return null (elastic#32811) Unmute WildFly tests in FIPS JVM (elastic#32814) [TEST] Force a stop to save rollup state before continuing (elastic#32787) [test] disable packaging tests for suse boxes Mute IndicesRequestIT#testBulk [ML][DOCS] Refer to rules feature as custom rules (elastic#32785)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a java time version of the existing rounding classes, which features the same test suite and a small test class to check if serialization works as expected.