Fix forbiddenapis on java 11 #33116
Merged
alpar-t merged 4 commits intoelastic:masterfrom Aug 27, 2018
Merged
Conversation
alpar-t
added
>non-issue
:Delivery/Build
vladimirdolzhenko
suggested changes
Aug 24, 2018
Contributor
vladimirdolzhenko
left a comment
vladimirdolzhenko
left a comment
There was a problem hiding this comment.
look good, I left a minor note
|
|
||
| public class ForbiddenApisCliTask extends DefaultTask { | ||
|
|
||
| private final Logger logger = Logging.getLogger(ForbiddenApisCliTask.class); |
Contributor
There was a problem hiding this comment.
should it be static ?
private static final Logger logger
Contributor
Author
There was a problem hiding this comment.
We don't seem to be consistent with this. I don't know if log4j has any recommendation, slf4j no longer favors this https://www.slf4j.org/faq.html#declared_static
|
|
||
| /** | ||
| * See {@link GetJobRequest#isAllowNoJobs()} | ||
| * @param allowNoJobs |
Contributor
There was a problem hiding this comment.
don't need to drop the javadoc param
Contributor
Author
There was a problem hiding this comment.
We do, this is not valid in java 11 without any further details.
Contributor
There was a problem hiding this comment.
surprise, surprise
vladimirdolzhenko
approved these changes
Aug 24, 2018
Contributor
|
LGTM |
Member
|
We didn't used to make loggers static because we couldn't get the node name
in them. I fixed that recenlty. I prefer static but don't care enough to
block any PRs over it. And there are still some cars where it can't be
static, namely when they include the shard or index id. Long story short:
we did the old thing for a reason that is no longer true, use your best
judgement now and don't rely on past patterns.
…On Fri, Aug 24, 2018, 7:13 AM Vladimir Dolzhenko ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
x-pack/protocol/src/main/java/org/elasticsearch/protocol/xpack/ml/GetJobRequest.java
<#33116 (comment)>
:
> @@ -90,7 +90,6 @@ public GetJobRequest(String... jobIds) {
/**
* See ***@***.*** GetJobRequest#isAllowNoJobs()}
- * @param allowNoJobs
surprise, surprise
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#33116 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLoprFcpo7cFSP6tJApwMiMmFhgkCJks5uT9_1gaJpZM4WKxKV>
.
|
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Aug 27, 2018
Cap forbiddenapis to java version 10
jasontedor
added a commit
that referenced
this pull request
Aug 27, 2018
* master: Adjust BWC version on mapping version Token API supports the client_credentials grant (#33106) Build: forked compiler max memory matches jvmArgs (#33138) Introduce mapping version to index metadata (#33147) SQL: Enable aggregations to create a separate bucket for missing values (#32832) Fix grammar in contributing docs SECURITY: Fix Compile Error in ReservedRealmTests (#33166) APM server monitoring (#32515) Support only string `format` in date, root object & date range (#28117) [Rollup] Move toBuilders() methods out of rollup config objects (#32585) Fix forbiddenapis on java 11 (#33116) Apply publishing to genreate pom (#33094) Have circuit breaker succeed on unknown mem usage Do not lose default mapper on metadata updates (#33153) Fix a mappings update test (#33146) Reload Secure Settings REST specs & docs (#32990) Refactor CachingUsernamePassword realm (#32646)
jasontedor
added a commit
that referenced
this pull request
Aug 27, 2018
* 6.x: Introduce mapping version to index metadata (#33147) Move non duplicated actions back into xpack core (#32952) HLRC: Create server agnostic request and response (#32912) Build: forked compiler max memory matches jvmArgs (#33138) * Added breaking change section for GROUP BY behavior: now it considers null or empty values as a separate group/bucket. Previously, they were ignored. * This is part of backporting of #32832 SQL: Enable aggregations to create a separate bucket for missing values (#32832) [TEST] version guard for reload rest-api-spec Fix grammar in contributing docs APM server monitoring (#32515) Support only string `format` in date, root object & date range (#28117) [Rollup] Move toBuilders() methods out of rollup config objects (#32585) Accept Gradle build scan agreement (#30645) Fix forbiddenapis on java 11 (#33116) Run forbidden api checks with runtimeJavaVersion (#32947) Apply publishing to genreate pom (#33094) Fix a mappings update test (#33146) Reload Secure Settings REST specs & docs (#32990) Refactor CachingUsernamePassword realm (#32646)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forbidden APIs doesn't yet support Java 11, so use the signatures from 10 when running on 11.
Closes #33082.