Skip to content

Use Lucene history in primary-replica resync#33178

Merged
dnhatn merged 2 commits intoelastic:ccrfrom
dnhatn:resync-with-soft-deletes
Aug 28, 2018
Merged

Use Lucene history in primary-replica resync#33178
dnhatn merged 2 commits intoelastic:ccrfrom
dnhatn:resync-with-soft-deletes

Conversation

@dnhatn
Copy link
Copy Markdown
Member

@dnhatn dnhatn commented Aug 27, 2018

This commit makes primary-replica resyncer use Lucene as the source of history operation instead of translog if soft-deletes is enabled. With this change, we no longer expose translog snapshot directly in IndexShard.

Relates #29530

/cc @bleskes

This commit makes primary-replica resyncer use Lucene as the source of history operations instead of translog if soft-deletes is enabled.
@dnhatn dnhatn added >feature :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Aug 27, 2018
@dnhatn dnhatn requested review from jasontedor and s1monw August 27, 2018 16:52
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

Copy link
Copy Markdown
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM!

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Aug 28, 2018

@elasticmachine test this please

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Aug 28, 2018

Thanks @s1monw and @jasontedor.

@dnhatn dnhatn merged commit e2b931e into elastic:ccr Aug 28, 2018
@dnhatn dnhatn deleted the resync-with-soft-deletes branch August 28, 2018 14:44
dnhatn added a commit that referenced this pull request Aug 28, 2018
This commit makes primary-replica resyncer use Lucene as the source of
history operation instead of translog if soft-deletes is enabled. With
this change, we no longer expose translog snapshot directly in IndexShard.

Relates #29530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants