[CCR] Rename idle_shard_retry_delay to poll_timout in auto follow patterns#33821
Conversation
martijnvg
added
review
:Distributed/CCR
|
Pinging @elastic/es-distributed |
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Is the idea here that since we plan to implement long polling for auto-follow patterns, we should name this parameter to poll timeout now (even though it doesn't mean a poll timeout yet)?
If so, I am onboard with this and this LGTM. If not, what is the idea here?
Sorry I should have described this PR better. So this parameter, if set, is used to set poll timeout in the follow index request, which then sets the poll timeout of the shard follow task. However the name we used in auto follow patterns was still |
…etry_delay_to_poll_timeout
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I see. That’s still fine. LGTM.
* master: (46 commits) Fixing assertions in integration test (elastic#33833) [CCR] Rename idle_shard_retry_delay to poll_timout in auto follow patterns (elastic#33821) HLRC: Delete ML calendar (elastic#33775) Move DocsStats into Engine (elastic#33835) [Docs] Clarify accessing Date methods in painless (elastic#33560) add elasticsearch-shard tool (elastic#32281) Cut over to unwrap segment reader (elastic#33843) SQL: Fix issue with options for QUERY() and MATCH(). (elastic#33828) Emphasize that filesystem-level backups don't work (elastic#33102) Use the global doc id to generate a random score (elastic#33599) Add minimal sanity checks to custom/scripted similarities. (elastic#33564) Profiler: Don’t profile NEXTDOC for ConstantScoreQuery. (elastic#33196) [CCR] Change FollowIndexAction.Request class to be more user friendly (elastic#33810) SQL: day and month name functions tests locale providers enforcement (elastic#33653) TESTS: Set SO_LINGER = 0 for MockNioTransport (elastic#32560) Test: Relax jarhell gradle test (elastic#33787) [CCR] Fail with a descriptive error if leader index does not exist (elastic#33797) Add ES version 6.4.2 (elastic#33831) MINOR: Remove Some Dead Code in Scripting (elastic#33800) Ensure realtime `_get` and `_termvectors` don't run on the network thread (elastic#33814) ...
3 participants
No description provided.