SQL: Move away internally from JDBCType to SQLType#33913
Merged
costin merged 1 commit intoelastic:masterfrom Sep 22, 2018
Merged
SQL: Move away internally from JDBCType to SQLType#33913costin merged 1 commit intoelastic:masterfrom
costin merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
costin
added a commit
that referenced
this pull request
Sep 22, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Replace JDBCType enum with SQLType interface for extensibility Fix #33094
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step in allowing our own custom types (such as
Interval) internally and within JDBC as we're moving away from a fixed enum to a pluggable interface (which is implemented byJDBCTypeas well).Fix #33904