TESTS: Enable DEBUG Logging in Flaky Test#34091
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Sep 27, 2018
original-brownbear:remote-cluster-conn-concurrency-cleanup
Merged
TESTS: Enable DEBUG Logging in Flaky Test#34091original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:remote-cluster-conn-concurrency-cleanup
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:remote-cluster-conn-concurrency-cleanup
Conversation
* This should surface what errors are thrown on CI and in org.elasticsearch.transport.RemoteClusterConnection.ConnectHandler#collectRemoteNodes (the sequence of caught error in the last catch block and moving on to the next seed node seems to be the only path by which the errors logged in #33756 could come about) * Relates #33756
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@nik9000 thanks! |
original-brownbear
deleted the
remote-cluster-conn-concurrency-cleanup
branch
original-brownbear
added a commit
that referenced
this pull request
Sep 27, 2018
* This should surface what errors are thrown on CI and in org.elasticsearch.transport.RemoteClusterConnection.ConnectHandler#collectRemoteNodes (the sequence of caught error in the last catch block and moving on to the next seed node seems to be the only path by which the errors logged in #33756 could come about) * Relates #33756
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 27, 2018
* master: (25 commits) [DOCS] Synchronize location of Breaking Changes (elastic#33588) [DOCS] Synchronizes captialization in top-level titles (elastic#33605) [SQL] Clean up LogicalPlanBuilder#doJoin (elastic#34048) Fix remote cluster seeds fallback (elastic#34090) [ML][HLRC] Replace REST-based ML test cleanup with the ML client (elastic#34109) Handle MatchNoDocsQuery in span query wrappers (elastic#34106) Update MovAvgIT AwaitsFix bug url Bad regex in CORS settings should throw a nicer error (elastic#34035) [HLRC] Support for role mapper expression dsl (elastic#33745) Watcher: Reduce script cache churn by checking for mustache tags (elastic#33978) Fold EngineSearcher into Engine.Searcher (elastic#34082) Mute SpanMultiTermQueryBuilderTests#testToQuery TESTS: Enable DEBUG Logging in Flaky Test (elastic#34091) TEST: Add engine is closed as expected failure msg Adjust bwc version for max_seq_no_of_updates Build DocStats from SegmentInfos in ReadOnlyEngine (elastic#34079) When creating wildcard queries, use MatchNoDocsQuery when the field type doesn't exist. (elastic#34093) [DOCS] Moves graph to docs folder (elastic#33472) Mute MovAvgIT#testHoltWintersNotEnoughData Security: use default scroll keepalive (elastic#33639) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* This should surface what errors are thrown on CI and in org.elasticsearch.transport.RemoteClusterConnection.ConnectHandler#collectRemoteNodes (the sequence of caught error in the last catch block and moving on to the next seed node seems to be the only path by which the errors logged in #33756 could come about) * Relates #33756
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and in org.elasticsearch.transport.RemoteClusterConnection.ConnectHandler#collectRemoteNodes
(the sequence of caught error in the last catch block (https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/transport/RemoteClusterConnection.java#L544) and moving on to the next seed node seems to be the only path by which the error logged in RemoteClusterConnectionTests#testCloseWhileConcurrentlyConnecting leaks a connection #33756 (
RuntimeExceptionwithout message from a successful connect callback and then subsequent cancellation because closed exception on the same listener) could come about)Can't reproduce the issue in #33756 at all locally (tried 100k+ runs on OSX, Ubuntu and CentOS), but I think this should make it relatively straightforward to track this down.