TESTING.asciidoc fix examples using forbidden annotation#34515
Merged
alpar-t merged 2 commits intoelastic:masterfrom Oct 23, 2018
Merged
TESTING.asciidoc fix examples using forbidden annotation#34515alpar-t merged 2 commits intoelastic:masterfrom
alpar-t merged 2 commits intoelastic:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Nightlyhas been added to the forbidden test annotations :elasticsearch/buildSrc/src/main/resources/forbidden/es-test-signatures.txt
Line 24 in 237650e
guaranteeing that no tests can be annotated as
@Nightly.This PR removes any examples containing
@Nightly, so that contributors do not try to implement, filter or run nightly tests.