Increment settings version when upgrading index#34566
Merged
jasontedor merged 3 commits intoelastic:masterfrom Oct 17, 2018
Merged
Increment settings version when upgrading index#34566jasontedor merged 3 commits intoelastic:masterfrom
jasontedor merged 3 commits intoelastic:masterfrom
Conversation
When we upgrade an index, we set the settings version upgraded setting. This should be considered a settings change, and therefore we need to increment the settings version. This commit addresses that.
jasontedor
added
>non-issue
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-infra |
s1monw
reviewed
Oct 17, 2018
server/src/test/java/org/elasticsearch/cluster/metadata/UpgradeIndexSettingsIT.java
Show resolved
Hide resolved
s1monw
approved these changes
Oct 17, 2018
Member
Author
|
@elasticmachine test this please |
Member
Author
|
@elasticmachine run sample packaging tests |
jasontedor
added a commit
that referenced
this pull request
Oct 17, 2018
When we upgrade an index, we set the settings version upgraded setting. This should be considered a settings change, and therefore we need to increment the settings version. This commit addresses that.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
When we upgrade an index, we set the settings version upgraded setting. This should be considered a settings change, and therefore we need to increment the settings version. This commit addresses that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we upgrade an index, we set the settings version upgraded setting. This should be considered a settings change, and therefore we need to increment the settings version. This commit addresses that.
Relates #34429