Add RunOnce utility class that executes a Runnable exactly once#35484
Closed
tlrx wants to merge 1 commit intoelastic:masterfrom
Closed
Add RunOnce utility class that executes a Runnable exactly once#35484tlrx wants to merge 1 commit intoelastic:masterfrom
tlrx wants to merge 1 commit intoelastic:masterfrom
Conversation
tlrx
added
>enhancement
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
reviewed
Nov 13, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a drive-by comment.
| * A class which wraps an existing {@link Runnable} and allows to execute it exactly once | ||
| * whatever the number of times the wrapped {@link Runnable#run()} method is called. | ||
| */ | ||
| public class RunOnce implements Runnable { |
Member
There was a problem hiding this comment.
We already have at least one implementation of this in the codebase: WorkerBulkByScrollTakeState#RunOnce. Can we relocate that code instead? Also, it is lacking tests. I think it could go in separately in a PR that adds tests along side it.
Member
Author
|
Superseded by #35489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a simple
RunOnceclass that can be used to execute aRunnableexactly once.Related to #34902 (comment)