[HLRC] Add support for put privileges API#35679
Merged
bizybot merged 17 commits intoelastic:masterfrom Dec 9, 2018
Merged
Conversation
This commit adds support for API to create or update application privileges. Note: I have used the ApplicationPrivilege and Tests from the changes done for get privileges API (by Ioannis) and have modified to support toXContent.
bizybot
added
v7.0.0
:Core/Java High Level REST Client
:Security/Authorization
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/es-security |
98 tasks
jkakavas
reviewed
Nov 21, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java
Outdated
Show resolved
Hide resolved
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Show resolved
Hide resolved
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/test/java/org/elasticsearch/client/security/PutPrivilegesResponseTests.java
Show resolved
Hide resolved
added 6 commits
November 22, 2018 09:47
- Corrected the toXContent for PutPrivilegesRequest for multiple privileges in application. - Changes to address TODO in testGetPrivileges - modified tests to test the scenario that got missed earlier
+Fix random test failure
tvernum
reviewed
Nov 27, 2018
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
I left some suggestions.
...nt/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesRequest.java
Show resolved
Hide resolved
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Show resolved
Hide resolved
...t-high-level/src/test/java/org/elasticsearch/client/security/PutPrivilegesResponseTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
jkakavas
reviewed
Nov 27, 2018
jkakavas
reviewed
Nov 27, 2018
tvernum
reviewed
Dec 3, 2018
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
tvernum
requested changes
Dec 4, 2018
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/PutPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
bizybot
added a commit
that referenced
this pull request
Dec 9, 2018
This commit adds support for API to create or update application privileges in high-level rest client.
jasontedor
added a commit
to liketic/elasticsearch
that referenced
this pull request
Dec 9, 2018
* elastic/6.x: (37 commits) [HLRC] Added support for Follow Stats API (elastic#36253) Exposed engine must have all ops below gcp during rollback (elastic#36159) TEST: Always enable soft-deletes in ShardChangesTests Use delCount of SegmentInfos to calculate numDocs (elastic#36323) Add soft-deletes upgrade tests (elastic#36286) Remove LocalCheckpointTracker#resetCheckpoint (elastic#34667) Option to use endpoints starting with _security (elastic#36379) [CCR] Restructured QA modules (elastic#36404) RestClient: on retry timeout add root exception (elastic#25576) [HLRC] Add support for put privileges API (elastic#35679) HLRC: Add rollup search (elastic#36334) Explicitly recommend to forceMerge before freezing (elastic#36376) Rename internal repository actions to be internal (elastic#36377) Core: Remove parseDefaulting from DateFormatter (elastic#36386) [ML] Prevent stack overflow while copying ML jobs and datafeeds (elastic#36370) Docs: Fix Jackson reference (elastic#36366) [ILM] Fix issue where index may not yet be in 'hot' phase (elastic#35716) Undeprecate /_watcher endpoints (elastic#36269) Docs: Fix typo in bool query (elastic#36350) HLRC: Add delete template API (elastic#36320) ...
tomcallahan
added
>enhancement
and removed
:Security/Authorization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for API to create or update
application privileges in high-level rest client.