Skip to content

[TEST] fix invalid ExplainLifecycleRequest in tests#35804

Merged
talevy merged 1 commit intoelastic:masterfrom
talevy:test-fix-explain-req
Nov 21, 2018
Merged

[TEST] fix invalid ExplainLifecycleRequest in tests#35804
talevy merged 1 commit intoelastic:masterfrom
talevy:test-fix-explain-req

Conversation

@talevy
Copy link
Copy Markdown
Contributor

@talevy talevy commented Nov 21, 2018

what the title says. tests were constructing ExplainLifecycleRequest objects with an empty array of indices, which is not allowed.

@talevy talevy requested a review from AthenaEryma November 21, 2018 21:23
@talevy talevy added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. labels Nov 21, 2018
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features

Copy link
Copy Markdown
Contributor

@AthenaEryma AthenaEryma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 927b242 into elastic:master Nov 21, 2018
@talevy talevy deleted the test-fix-explain-req branch November 21, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. >test Issues or PRs that are addressing/adding tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants