Skip to content

Deprecate negative scores in functon_score query#35865

Merged
mayya-sharipova merged 3 commits intoelastic:6.xfrom
mayya-sharipova:script-score-ensure-nonnegative-scores-6.x
Nov 23, 2018
Merged

Deprecate negative scores in functon_score query#35865
mayya-sharipova merged 3 commits intoelastic:6.xfrom
mayya-sharipova:script-score-ensure-nonnegative-scores-6.x

Conversation

@mayya-sharipova
Copy link
Copy Markdown
Contributor

Relates to #33309, backport for #35709

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search

// CONSOLE
// TEST[setup:twitter]

NOTE: Scores produced by the `script_score` function must be non-negative,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can maybe make it a WARNING: ?

values of the field with a range filter to avoid this, or use `log1p` and
`ln1p`.

NOTE: Scores produced by the `field_value_score` function must be
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@mayya-sharipova mayya-sharipova merged commit 3132c29 into elastic:6.x Nov 23, 2018
@mayya-sharipova mayya-sharipova deleted the script-score-ensure-nonnegative-scores-6.x branch November 23, 2018 20:17
@jimczi jimczi removed the backport label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>deprecation :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v6.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants