[ML] Prefer cluster state config to index documents#36014
Merged
davidkyle merged 4 commits intoelastic:feature-jindex-6xfrom Nov 29, 2018
Merged
[ML] Prefer cluster state config to index documents#36014davidkyle merged 4 commits intoelastic:feature-jindex-6xfrom
davidkyle merged 4 commits intoelastic:feature-jindex-6xfrom
Conversation
This reverts commit 417624f.
Collaborator
|
Pinging @elastic/ml-core |
Member
|
No issues with the PR really, but what is the reasoning for the reverting? Why should we prefer the cluster state over the indexed configs? |
benwtrent
approved these changes
Nov 28, 2018
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Well @davidkyle , there you stand, with your code in your hands:
https://www.youtube.com/watch?v=c0SvsinEUfY
:D
Member
Author
|
Actually doing this uncovered a bug where on closing a job the check that the job's datafeed must be stopped was only checking the index configs and not the clusterstate jobs. This explains an intermittent failure I'd seen in the rolling upgrade tests. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial revert of #35940
Duplicate configs in both the clusterstate and index are still possible but now clusterstate config is preferred.
After discussing the changes in #35940 it was decided that during a move operation the original should always be preferred to the new until the operation has completed. This revert also makes the code simpler to read.
Alas the wasted time
@benwtrent you reviewed #35940 would you take a look at this please