Deprecate the _termvector endpoint.#36098
Merged
jtibshirani merged 3 commits intoelastic:masterfrom Nov 30, 2018
Merged
Conversation
jtibshirani
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
jpountz
reviewed
Nov 30, 2018
| // we keep usage of _termvector as alias for now | ||
| controller.registerHandler(GET, "/{index}/{type}/_termvector", this); | ||
| controller.registerHandler(POST, "/{index}/{type}/_termvector", this); | ||
| controller.registerHandler(GET, "/{index}/{type}/{id}/_termvector", this); |
Contributor
There was a problem hiding this comment.
should we use registerWithDeprecatedHandler instead?
Contributor
Author
There was a problem hiding this comment.
Thanks, I had overlooked this.
jtibshirani
added a commit
that referenced
this pull request
Nov 30, 2018
This endpoint was replaced by _termvectors (plural) in #8484. We deprecated the relevant transport client methods, but didn't introduce a deprecation warning. My plan was to add a deprecation warning in 6.6, and stop supporting this endpoint in 7.0.
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This endpoint was replaced by
_termvectors(plural) in #8484. We deprecated the relevant transport client methods, but didn't introduce a deprecation warning. My plan was to add a deprecation warning in 6.6, and stop supporting this endpoint in 7.0.