Deprecate /_xpack/monitoring/* in favor of /_monitoring/*#36130
Merged
jakelandis merged 3 commits intoelastic:masterfrom Dec 3, 2018
Merged
Deprecate /_xpack/monitoring/* in favor of /_monitoring/*#36130jakelandis merged 3 commits intoelastic:masterfrom
jakelandis merged 3 commits intoelastic:masterfrom
Conversation
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs. * Add deprecation for /_xpack/monitoring/* in favor of /monitoring/* * Removed xpack from the rest-api-spec and tests * Removed xpack from the Action name * Removed MonitoringRestHandler as an unnecessary abstraction * Minor corrections to comments Relates elastic#35958
jakelandis
added
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
requested changes
Dec 1, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment to the naming.
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
jakelandis
changed the title
jasontedor
requested changes
Dec 3, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Looking good now. Left a few minor comments.
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
11 tasks
spinscale
pushed a commit
that referenced
this pull request
Dec 4, 2018
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs. * Add deprecation for /_xpack/monitoring/_bulk in favor of /_monitoring/bulk * Removed xpack from the rest-api-spec and tests * Removed xpack from the Action name * Removed MonitoringRestHandler as an unnecessary abstraction * Minor corrections to comments Relates #35958
jakelandis
added a commit
to jakelandis/logstash
that referenced
this pull request
Mar 10, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958
jakelandis
added a commit
to jakelandis/logstash
that referenced
this pull request
Mar 11, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is part of our plan to deprecate and ultimately remove the
use of _xpack in the REST APIs.
Relates #35958
Note - since this is an internal API there is not an associated HLRC or docs. Also, i removed a comment a
/_xpack/monitoring/_setupendpoint... I assume that is a stale comment since I can not find that endpoint.