Deprecate X-Pack centric watcher endpoints#36218
Conversation
|
Pinging @elastic/es-core-features |
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
The endpoint can not be /watcher, that is not a reserved name. It needs to be /_watcher so that it can not possibly conflict with existing indices that users might have today.
|
oh my, thank you for that clarification @jasontedor |
|
@jasontedor updated, as well as reverted any changes i made to the transport layer. |
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I am missing where the existing endpoints are deprecated?
|
Because I am an idiot and I was trying to do this before finishing other work I should have finished first, and did not pay attention in the process... Let me properly do this and then Ill ping you. Im sorry for causing this many re-reviews on what should've been an easy PR. |
|
@elasticmachine run the gradle build tests 1 |
|
I have to do the 6.x undeprecate first, and then I can rerun the tests here. |
|
This depends on #36269 merging before the tests will go green. |
|
@elasticmachine run the gradle build tests 1 |
1 similar comment
|
@elasticmachine run the gradle build tests 1 |
|
@elasticmachine run the gradle build tests 2 |
1 similar comment
|
@elasticmachine run the gradle build tests 2 |
4 participants
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs.
Relates #35958